Fix rebundling apps with app extensions (.share only for now) #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
commented
Jun 4, 2021
| throw new Error('Invalid parameters for adjustInfoPlist'); | ||
| } | ||
| if (file.indexOf('.appex/') != -1) { | ||
| bundleid += '.share'; |
There was a problem hiding this comment.
network extensions may use: .network-extension so this is just a partial fix.
Probably the way to go is to check for the NSExtension array and see which is the NSExtensionPrincipalClass used for each appex
There was a problem hiding this comment.
.SiriExtension for NSExtension.NSExtensionPointIdentifier == com.apple.intents-service
There was a problem hiding this comment.
com.apple.networkextension.packet-tunnel -> network-extension
There was a problem hiding this comment.
shouldn't this happen only if bundleId is defined? AFAIK overriding the bundle id is optional
There was a problem hiding this comment.
LOL for the single letter contributor
trufae
force-pushed
the
fix-appex-rebundle
branch
from
d7ccca0
to
cde5a20
Compare
norf0000
approved these changes
Jul 8, 2021
trufae
force-pushed
the
fix-appex-rebundle
branch
from
cde5a20
to
ac9fa81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.