Merge pull request #15 from nox7/1.4.1

Do not update the PRIMARY KEY
nox7 · Aug 30, 2021 · 8fcd4b0 · 8fcd4b0
2 parents 496a4e7 + d20699a
commit 8fcd4b0
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/src/ORM/Abyss.php b/src/ORM/Abyss.php
@@ -295,6 +295,7 @@ public function buildSaveQuery(
 		): array {
 			$model = $classInstance->getModel();
 			$tableName = $model->getName();
+			$primaryKeyName = $this->getPrimaryKey($model);
 			$columnNameList = [];
 			$columnValues = [];
 			$rawQueryColumnValues = [];
@@ -326,7 +327,11 @@ public function buildSaveQuery(
 
 			foreach($columnNameList as $columnName){
 				$columnNameListAsMySQLSyntax .= sprintf("`%s`,", $columnName);
-				$columnUpdateMySQLSyntax .= sprintf("`%s` = VALUES(`%s`),", $columnName, $columnName);
+
+				// Do not update the primary key
+				if ($columnName !== $primaryKeyName) {
+					$columnUpdateMySQLSyntax .= sprintf("`%s` = VALUES(`%s`),", $columnName, $columnName);
+				}
 			}
 
 			// Remove the trailing commas
@@ -455,8 +460,8 @@ public function deleteRowByPrimaryKey(ModelInstance $classInstance): void{
 		}
 
 		/**
-		* Syncs all models to the database
-		*/
+		 * Syncs all models to the database
+		 */
 		public function syncModels(): void{
 			$fileNames = array_diff(scandir(self::$modelsDirectory), ['.','..']);
 			foreach ($fileNames as $fileName){
@@ -565,8 +570,8 @@ protected function doesTableExist(string $tableName): bool{
 		 */
 		protected function isColumnAUniqueIndex(string $tableName, string $columnName): bool{
 			$result = $this->getConnection()->query(sprintf(
-				"SHOW INDEXES FROM `%s` WHERE `Column_name`='%s' AND Non_unique=0 AND Key_name != \"PRIMARY\"",
-				$tableName, $columnName
+					"SHOW INDEXES FROM `%s` WHERE `Column_name`='%s' AND Non_unique=0 AND Key_name != \"PRIMARY\"",
+					$tableName, $columnName
 				)
 			);
 			return $result->num_rows > 0;
@@ -753,8 +758,8 @@ protected function updateExistingTable(MySQLModelInterface $model): void{
 		}
 
 		/**
-		* Creates a table following a model
-		*/
+		 * Creates a table following a model
+		 */
 		protected function createNewTable(MySQLModelInterface $model): void{
 			$connection = $this->getConnection();
 			$tableName = $model->getName();