Skip to content

Commit

Permalink
Do not error when obsolete methods are used
Browse files Browse the repository at this point in the history
  • Loading branch information
nozzlegear committed May 28, 2019
1 parent 341b6b2 commit dd7fb28
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ShopifySharp/Services/Fulfillment/FulfillmentService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public virtual async Task<Fulfillment> CreateAsync(long orderId, Fulfillment ful
/// <param name="notifyCustomer">Whether the customer should be notified that the fulfillment
/// has been created.</param>
/// <returns>The new <see cref="Fulfillment"/>.</returns>
[Obsolete("The notifyCustomer parameter can already be found on the Fulfillment object. This extra parameter will be removed from FulfillmentService.UpdateAsync in a future release.")]
[Obsolete("The notifyCustomer parameter can already be found on the Fulfillment object. This extra parameter will be removed from FulfillmentService.UpdateAsync in a future release.", false)]
public virtual async Task<Fulfillment> CreateAsync(long orderId, Fulfillment fulfillment, bool notifyCustomer)
{
// Set the notifyCustomer property on the fulfillment
Expand Down Expand Up @@ -137,7 +137,7 @@ public virtual async Task<Fulfillment> UpdateAsync(long orderId, long fulfillmen
/// <param name="fulfillmentId">Id of the object being updated.</param>
/// <param name="fulfillment">The <see cref="Fulfillment"/> to update.</param>
/// <returns>The updated <see cref="Fulfillment"/>.</returns>
[Obsolete("The notifyCustomer parameter can already be found on the Fulfillment object. This extra parameter will be removed from FulfillmentService.UpdateAsync in a future release.")]
[Obsolete("The notifyCustomer parameter can already be found on the Fulfillment object. This extra parameter will be removed from FulfillmentService.UpdateAsync in a future release.", false)]
public virtual async Task<Fulfillment> UpdateAsync(long orderId, long fulfillmentId, Fulfillment fulfillment, bool notifyCustomer = false)
{
// Set the notifyCustomer property on the fulfillment
Expand Down

0 comments on commit dd7fb28

Please sign in to comment.