Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for secrets on workflow_call #658

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

glungley
Copy link
Contributor

@glungley glungley commented Jul 15, 2024

Approach to fix the secrets parts of #621

@glungley
Copy link
Contributor Author

glungley commented Sep 3, 2024

@npalm, seems you still need to approve if you're happy for the remaining checks to run

@npalm
Copy link
Owner

npalm commented Sep 3, 2024

most likely you just need to run yarn format

@glungley
Copy link
Contributor Author

glungley commented Oct 1, 2024

@npalm could you merge this?

Copy link
Owner

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks in general good, but I think we should ensure secrets are optional. Made two small comments.

src/action-docs.ts Show resolved Hide resolved
__tests__/fixtures/workflow/workflow.yml Outdated Show resolved Hide resolved
Copy link
Owner

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glungley thanks for the PR, and sorry for the long cycle time.

@npalm npalm merged commit f427c9a into npalm:main Oct 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants