Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Convert.ToDateTime as a supported method for translation #1297 #1298

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added Convert.ToDateTime as a supported method for translation #1297 #1298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0a8a80
Added Convert.ToDateTime as a supported method for translation #1297
TanielianVB Mar 4, 2020
42b2843
Merge branch 'dev' of https://github.com/npgsql/efcore.pg into dev
TanielianVB Mar 20, 2020
f6170df
Merge remote-tracking branch 'upstream/dev' into dev
TanielianVB Sep 4, 2020
6baa90f
Resolved changes requested during review
TanielianVB Sep 4, 2020
dba3629
Improved Convert.ToDateTime test
TanielianVB Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/EFCore.PG/Query/ExpressionTranslators/Internal/NpgsqlConvertTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ public class NpgsqlConvertTranslator : IMethodCallTranslator
{
static readonly Dictionary<string, string> TypeMapping = new Dictionary<string, string>
{
[nameof(Convert.ToBoolean)] = "bool",
[nameof(Convert.ToByte)] = "smallint",
[nameof(Convert.ToDateTime)] = "timestamp with time zone",
[nameof(Convert.ToDecimal)] = "numeric",
[nameof(Convert.ToDouble)] = "double precision",
[nameof(Convert.ToInt16)] = "smallint",
[nameof(Convert.ToInt32)] = "int",
[nameof(Convert.ToInt64)] = "bigint",
[nameof(Convert.ToString)] = "text"
[nameof(Convert.ToBoolean)] = "bool",
[nameof(Convert.ToByte)] = "smallint",
[nameof(Convert.ToDateTime)] = "timestamp with time zone",
[nameof(Convert.ToDecimal)] = "numeric",
[nameof(Convert.ToDouble)] = "double precision",
[nameof(Convert.ToInt16)] = "smallint",
[nameof(Convert.ToInt32)] = "int",
[nameof(Convert.ToInt64)] = "bigint",
[nameof(Convert.ToString)] = "text"
};

static readonly List<Type> SupportedTypes = new List<Type>
Expand Down
14 changes: 13 additions & 1 deletion test/EFCore.PG.FunctionalTests/Query/NorthwindFunctionsQueryNpgsqlTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Linq;
using System.Text.RegularExpressions;
using System.Threading.Tasks;
Expand Down Expand Up @@ -41,6 +41,18 @@ public override Task Where_math_log_new_base(bool async)
public override Task Convert_ToString(bool async)
=> base.Convert_ToString(async);

[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public virtual async Task Convert_ToDateTime(bool async)
{
await AssertQuery(
async,
ss => ss.Set<Order>().Where(o => o.OrderDate.HasValue && o.OrderDate == Convert.ToDateTime(o.OrderDate.ToString())),
TanielianVB marked this conversation as resolved.
Show resolved Hide resolved
entryCount: 830);

AssertContainsSqlFragment(@"WHERE (o.""OrderDate"" IS NOT NULL) AND (o.""OrderDate"" = CAST(CAST(o.""OrderDate"" AS text) AS timestamp without time zone))");
}

#region Substring

[ConditionalTheory]
Expand Down