Implement Precompiled Query Tests #3289
Conversation
|
@ChrisJollyAU thanks for working on this, much appreciated!
I think it's simply a matter of including a reference to the assembly in NpgsqlPrecompiledQueryTestHelpers, just like you're already doing for the EF provider, no? |
|
@roji Yep. That works fine. Thanks Removed a test |
|
@roji In PrecompiledSqlPregenerationQueryNpgsqlTest.cs there is a bunch of tests commented out. Think they got copied over originally from the SQL Server version. Think they are applicable for postgresql? Got one remaining test failing |
test/EFCore.PG.FunctionalTests/TestUtilities/NpgsqlPrecompiledQueryTestHelpers.cs
Outdated
Show resolved
Hide resolved
…QueryTestHelpers.cs Co-authored-by: Shay Rojansky <roji@roji.org>
|
@roji The above mentioned test is failing due to case sensitivity. The base is set up to expect a case-insensitive startswith (aka LIKE) but postgresql defaults to case sensitive Change the seeded data from "Blog" to "blog" or completely override the test and use "Blog" as the starts parameter? |
There was a problem hiding this comment.
Thanks, this looks good! We probably need to add test coverage for Npgsql-specific expressions (and also actually implement the quotability for all of them!), but that can be done in a separate PR... Am happy to accept a PR if you're interested in that work!
Re test Two_captured_variables_in_different_lambdas, that's a bug in the EF test - I submitted #34731 to fix this - for 10. In the meantime, can you implement the Npgsql override by doing Assert.Throws() when calling the test, this way we're alerted when the upstream fix is synced in 10 and fix it?
|
BTW note that there has been some flakiness in the CI, where some builds hang... I still need to look at it, but we currently aren't getting fully green builds (and that's OK). |
|
Fixed up the last test. Looks like they are all passing now. |
| return builder; | ||
| } | ||
|
|
||
| protected override async Task SeedAsync(PrecompiledQueryContext context) |
There was a problem hiding this comment.
@ChrisJollyAU noticed after merging that this is still overridden - is that needed for some reason, or is the base implementation good here?
There was a problem hiding this comment.
The seeding does need to be overridden. EFCore.PG doesn't like DateTime when the DateTimeKind is Unspecified
Most work except for a few exceptions: Concat, Except,Intersect,Union
Looks like we need to find a way to add a reference to
Npgsqlwhen its doing the compilation as the error is of the style:The type 'NpgsqlTsVector' is defined in an assembly that is not referenced. You must add a reference to assembly 'Npgsql, Version=8.0.3.0, Culture=neutral, PublicKeyToken=5d8b90d52f46fda7'.Contributes to #3257