Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of the ADO.NET batching API #3860

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Implementation of the ADO.NET batching API #3860

merged 1 commit into from
Aug 16, 2021

Conversation

roji
Copy link
Member

@roji roji commented Jun 19, 2021

No description provided.

@roji roji requested a review from vonzshik as a code owner June 19, 2021 19:42
@roji roji marked this pull request as draft June 19, 2021 19:44
@roji roji mentioned this pull request Jun 20, 2021
Closed
@roji roji force-pushed the BatchingAPI branch 2 times, most recently from 0a4e8f3 to cf3f491 Compare July 31, 2021 17:50
@roji roji changed the title Draft implementation of the ADO.NET batching API proposal Implementation of the ADO.NET batching API Jul 31, 2021
@roji roji marked this pull request as ready for review July 31, 2021 18:05
@roji
Copy link
Member Author

roji commented Jul 31, 2021

This is now more or less ready for integration in preview7 - tested against the latest dotnet SDK.

  • There are some incomplete corners which I'd rather handle a bit later - specifically around invalidation the preparation status of a batch if anything changes in any of its batch commands (e.g. text changes, some batch command is removed...).
  • Because of an issue in the preview7 implementation, DbBatch.Commands is typed as DbBatchCommand instead of NpgsqlBatchCommand. This is addressed in API fix to System.Data batching API dotnet/runtime#56525 and will be OK in rc1.

vonzshik
vonzshik reviewed Aug 15, 2021
View reviewed changes
Copy link
Contributor

@vonzshik vonzshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go. Everything looks correct, found a few things which stood out for me from a perf standpoint.

src/Npgsql/NpgsqlBatchCommandCollection.cs Outdated Show resolved Hide resolved
src/Npgsql/NpgsqlParameterCollection.cs Show resolved Hide resolved
test/Npgsql.Tests/BatchTests.cs Outdated Show resolved Hide resolved
src/Npgsql/NpgsqlParameterCollection.cs Outdated Show resolved Hide resolved
@roji roji requested a review from vonzshik August 16, 2021 10:58
@roji roji merged commit 0d8dd34 into main Aug 16, 2021
@roji roji deleted the BatchingAPI branch August 16, 2021 11:08
This was referenced Aug 16, 2021
Closed
Closed
@roji roji mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonzshik vonzshik vonzshik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roji @vonzshik