Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Do not write package.json if nothing changed #234

Closed
wants to merge 1 commit into from
Closed

Do not write package.json if nothing changed #234

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Feb 17, 2021

Need a similar fix for Shrinkwrap class.

Fix: #232

References

@isaacs
Do not write package.json if nothing changed
9c6cd63 
Need a similar fix for Shrinkwrap class.

Fix: #232
nlf
nlf approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty clear win, good test, this looks great 👍

@isaacs isaacs closed this in 7e8b824 Feb 18, 2021
@wraithgar wraithgar deleted the isaacs/do-not-write-package-json-if-unchanged branch April 22, 2021 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] should not write package.json file if nothing is being changed
2 participants
@isaacs @nlf