This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
feat: Save .npmrc files setting workspace-root in workspaces #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jul 31, 2021
Comment on lines
+533
to
+534
| if (node.isWorkspace && this[_saveWorkspaceRoot]) | ||
| await this[_writeWorkspaceRootConfig](node) |
There was a problem hiding this comment.
this shouldn't be written if the workspace root already exists in the npmrc file - only if it's missing (either the file, or that config value)
|
@isaacs closing this in order to archive the repo, as we're pulling arborist in as workspace. We're looking at this or something similar. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-to: npm/cli#3596
References