This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: always set originalLockfileVersion when doing shrinkwrap reset #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/empty-update-old-lockfile
branch
2 times, most recently
from
4fc3a53
to
6429b9d
Compare
Fix: npm/cli#3899 A shrinkwrap reset without specifying a lockfile version was triggering an old lockfile warning due to the originalLockfileVersion not being set prior to checking whether the lockfile was old.
lukekarrys
force-pushed
the
lk/empty-update-old-lockfile
branch
from
6429b9d
to
d310bd3
Compare
1 task
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: npm/cli#3899
A shrinkwrap reset without specifying a lockfile version was triggering
an old lockfile warning due to the originalLockfileVersion not being set
prior to checking whether the lockfile was old.