Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

fix: _findMissingEdges missing dependency due to inconsistent path separators #363

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/arborist/load-actual.js
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ module.exports = cls => class ActualLoader extends cls {
if (d.dummy) {
// it's a placeholder, so likely would not have loaded this dep,
// unless another dep in the tree also needs it.
const depPath = `${p}/node_modules/${name}`
const depPath = normalize(`${p}/node_modules/${name}`)
const cached = this[_cache].get(depPath)
if (!cached || cached.dummy) {
depPromises.push(this[_loadFSNode]({
Expand Down
45 changes: 45 additions & 0 deletions test/arborist/load-actual.js
Original file line number Diff line number Diff line change
Expand Up @@ -422,3 +422,48 @@ t.test('load global space with link deps', async t => {
},
})
})

t.test('no edge errors for nested deps', async t => {
const path = t.testdir({
'package.json': JSON.stringify({
name: 'a',
version: '1.0.0',
dependencies: {
b: '1.0.0',
},
}),
node_modules: {
b: {
'package.json': JSON.stringify({
name: 'b',
version: '1.0.0',
dependencies: {
c: '1.0.0',
},
}),
},
c: {
'package.json': JSON.stringify({
name: 'c',
version: '1.0.0',
}),
},
},
})

// disable treeCheck since it prevents the original issue from occuring
const ArboristNoTreeCheck = t.mock('../../lib/arborist', {
'../../lib/tree-check.js': tree => tree,
})
const loadActualNoTreeCheck = (path, opts) =>
new ArboristNoTreeCheck({ path, ...opts }).loadActual(opts)

const tree = await loadActualNoTreeCheck(path)

// assert that no outgoing edges have errors
for (const node of tree.inventory.values()) {
for (const [name, edge] of node.edgesOut.entries()) {
t.equal(edge.error, null, `node ${node.name} has outgoing edge to ${name} with error ${edge.error}`)
}
}
})