allow for passing object keys to searchopts to allow pagination

PR-URL: #2303 Credit: @nlf Close: #2303 Reviewed-by: @isaacs
npm · Dec 8, 2020 · 3db90d9 · 3db90d9
1 parent 0ef25b6
commit 3db90d9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/lib/utils/flat-options.js b/lib/utils/flat-options.js
@@ -3,6 +3,7 @@
 
 const log = require('npmlog')
 const crypto = require('crypto')
+const querystring = require('querystring')
 const npmSession = crypto.randomBytes(8).toString('hex')
 log.verbose('npm-session', npmSession)
 const { join } = require('path')
@@ -92,7 +93,7 @@ const flatten = obj => ({
     description: obj.description,
     exclude: obj.searchexclude,
     limit: obj.searchlimit || 20,
-    opts: obj.searchopts,
+    opts: querystring.parse(obj.searchopts),
     staleness: obj.searchstaleness,
   },
 

diff --git a/tap-snapshots/test-lib-utils-flat-options.js-TAP.test.js b/tap-snapshots/test-lib-utils-flat-options.js-TAP.test.js
@@ -95,7 +95,9 @@ Object {
     "description": "description",
     "exclude": "searchexclude",
     "limit": "searchlimit",
-    "opts": "searchopts",
+    "opts": Null Object {
+      "from": "1",
+    },
     "staleness": "searchstaleness",
   },
   "sendMetrics": "send-metrics",

diff --git a/test/lib/utils/flat-options.js b/test/lib/utils/flat-options.js
@@ -65,7 +65,7 @@ class MockConfig {
       description: 'description',
       searchexclude: 'searchexclude',
       searchlimit: 'searchlimit',
-      searchopts: 'searchopts',
+      searchopts: 'from=1',
       searchstaleness: 'searchstaleness',
       'dry-run': 'dry-run',
       'engine-strict': 'engine-strict',