Skip to content

Commit

Permalink
feat: set engines and prerelease for npm 10
Browse files Browse the repository at this point in the history
BREAKING CHANGE: npm now supports node `^18.17.0 || >=20.5.0`
  • Loading branch information
lukekarrys committed Jul 25, 2023
1 parent e5338af commit 5cfb487
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 30 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/audit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci-npmcli-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
os: windows-latest
shell: cmd
node-version:
- 18.x
- 20.x
runs-on: ${{ matrix.platform.os }}
defaults:
run:
Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down
18 changes: 7 additions & 11 deletions .github/workflows/ci-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down Expand Up @@ -116,12 +116,10 @@ jobs:
os: windows-latest
shell: cmd
node-version:
- 14.17.0
- 14.x
- 16.13.0
- 16.x
- 18.0.0
- 18.17.0
- 18.x
- 20.5.0
- 20.x
runs-on: ${{ matrix.platform.os }}
defaults:
run:
Expand Down Expand Up @@ -219,12 +217,10 @@ jobs:
os: macos-latest
shell: bash
node-version:
- 14.17.0
- 14.x
- 16.13.0
- 16.x
- 18.0.0
- 18.17.0
- 18.x
- 20.5.0
- 20.x
runs-on: ${{ matrix.platform.os }}
defaults:
run:
Expand Down
16 changes: 7 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down Expand Up @@ -71,12 +71,10 @@ jobs:
os: windows-latest
shell: cmd
node-version:
- 14.17.0
- 14.x
- 16.13.0
- 16.x
- 18.0.0
- 18.17.0
- 18.x
- 20.5.0
- 20.x
runs-on: ${{ matrix.platform.os }}
defaults:
run:
Expand Down Expand Up @@ -121,7 +119,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand All @@ -147,7 +145,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand All @@ -174,7 +172,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-node-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down Expand Up @@ -156,7 +156,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
"tap": "^16.3.4"
},
"engines": {
"node": "^14.17.0 || ^16.13.0 || >=18.0.0"
"node": "^18.17.0 || >=20.5.0"
}
},
"docs": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,6 @@
},
"license": "Artistic-2.0",
"engines": {
"node": "^14.17.0 || ^16.13.0 || >=18.0.0"
"node": "^18.17.0 || >=20.5.0"
}
}
2 changes: 1 addition & 1 deletion release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"packages": {
".": {
"package-name": "",
"prerelease": false
"prerelease": true
},
"workspaces/arborist": {
"prerelease": false
Expand Down
1 change: 1 addition & 0 deletions scripts/template-oss/root.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = {
'.github/workflows/release.yml': false,
},
},
ciVersions: ['18.17.0', '18.x', '20.5.0', '20.x'],
lockfile: true,
npm: '.',
defaultBranch: 'latest',
Expand Down

0 comments on commit 5cfb487

Please sign in to comment.