Skip to content

Commit

Permalink
fix: bump knownBroken to <12.5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
wraithgar authored and lukekarrys committed Mar 28, 2022
1 parent 0a957f5 commit 738a404
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = async process => {
// checks as early as possible so the user gets the error message.
const semver = require('semver')
const supported = require('../package.json').engines.node
const knownBroken = '<6.2.0 || 9 <9.3.0'
const knownBroken = '<12.5.0'

const nodejsVersion = process.version.replace(/-.*$/, '')
/* eslint-disable no-console */
Expand Down
4 changes: 2 additions & 2 deletions test/lib/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ t.test('unsupported node version', async t => {
const { cli } = await cliMock(t, {
globals: {
'console.error': (msg) => errors.push(msg),
'process.version': '10.0.0',
'process.version': '12.6.0',
},
})
await cli(process)
t.match(errors, [
'npm does not support Node.js 10.0.0',
'npm does not support Node.js 12.6.0',
'You should probably upgrade to a newer version of node as we',
'can\'t make any promises that npm will work with this version.',
])
Expand Down

0 comments on commit 738a404

Please sign in to comment.