Skip to content

Commit

Permalink
fixup! address PR review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
wraithgar committed Nov 3, 2021
1 parent 3fba006 commit c035821
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/commands/completion.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ const dumpScript = async () => {
// Really, one should not be tossing away EPIPE errors, or any
// errors, so casually. But, without this, `. <(npm completion)`
// can never ever work on OS X.
// Ignoring coverage, see 'non EPIPE errors cause failures' test.
// TODO Ignoring coverage, see 'non EPIPE errors cause failures' test.
/* istanbul ignore next */
if (er.errno === 'EPIPE')
res()
Expand Down
2 changes: 1 addition & 1 deletion lib/npm.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class Npm extends EventEmitter {
}
}

load () {
async load () {
if (!this.loadPromise) {
process.emit('time', 'npm:load')
this.log.pause()
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/npm-usage.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Configuration fields: npm help 7 config
npm@${npm.version} ${dirname(dirname(__dirname))}`
}

const allCommands = (npm) => {
const allCommands = async (npm) => {
if (npm.config.get('long'))
return usages(npm)
return ('\n ' + wrap(cmdList))
Expand Down
4 changes: 0 additions & 4 deletions test/fixtures/sandbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -292,10 +292,6 @@ class Sandbox extends EventEmitter {

const cmd = this[_npm].argv.shift()
return this[_npm].exec(cmd, this[_npm].argv)
// const cmd = this[_npm].argv.shift()
// const impl = await this[_npm].cmd(cmd)

// return impl.exec(this[_npm].argv)
}

async complete (command, argv, partial) {
Expand Down

0 comments on commit c035821

Please sign in to comment.