allow for passing object keys to searchopts to allow pagination #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
approved these changes
Dec 8, 2020
darcyclarke
added
Release 7.x
Update to accept query params as options, so we can paginate.
isaacs
force-pushed
the
nlf/search-opts
branch
from
e544405
to
3db90d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our search endpoint wants the query parameter
?from=2, for example, in order to do offsets for pagination purposes. we currently have no way to express that.this is the shortest path to resolving that problem, by allowing users to pass
--searchopts=from=2, parsing it as a query parameter, and then passing that resulting object to libnpmsearchthere's a corresponding pull request for libnpmsearch to ensure that this nested
optsparameter gets used.References
Related to npm/libnpmsearch#6