[BUG] Multiple related packages install fail due to wrong peerDependencies resolution #3666

sarunint · 2021-08-19T21:59:21Z

Is there an existing issue for this?

I have searched the existing issues

Current Behavior

(The content below is modified from #3171)

When having multiple packages relying on each others having the exact same version, trying to update them all via npm install fails when there is another package which loosely rely on them via "peerDependencies": "^x.x.x", due to npm7 erroneous resolution.

Real world example: Angular core packages are supposed to be installed with the exact same version, so for example @angular/common@12.1.1 has "peerDependencies": { "@angular/core": "12.1.1" } (note the exact version).

Until now everything is fine. You can update all versions to 12.2.1 in package.json, run npm install and it works.

But now add another package which relies on one of the core packages, for example @angular-devkit/build-angular@11.2.9 has a "peerDependencies": { "@angular/compiler-cli": "^11.0.0 || ^12.0.0-next" }.

~~Now if you update all versions to 11.2.10 in package.json and run npm install, it fails.~~

(The striketrough text issue has been solved in npm@7.20.3, as stated in #3171 (comment).)

This time, there are two more dependencies that become related in this, namely:

@angular/animations@12.1.1. Similar to @angular/common@12.1.1, this package has "peerDependencies": { "@angular/core": "12.1.1" }
ngx-clipboard@14.0.1, which is a clipboard library for Angular. This one has the following:

"peerDependencies": {
    "@angular/common": ">=10.0.0",
    "@angular/core": ">=10.0.0"
}

If you modify all 12.1.1 versions to 12.2.2 and run npm install, I get the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: npm-test@0.0.0
npm ERR! Found: @angular/animations@12.1.1
npm ERR! node_modules/@angular/animations
npm ERR!   @angular/animations@"12.2.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! @angular/animations@"12.2.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @angular/core@12.2.2
npm ERR! node_modules/@angular/core
npm ERR!   peer @angular/core@"12.2.2" from @angular/animations@12.2.2
npm ERR!   node_modules/@angular/animations
npm ERR!     @angular/animations@"12.2.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/sarunint/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/sarunint/.npm/_logs/2021-08-19T20_20_01_099Z-debug.log

I've created test packages to try to debug this issue, and published them to my GitLab registry.

I also discovered that the order of the package names does matter, surprisingly! As you can see with my test packages, I've dedicated package-4 to ngx-clipboard in the above example, and package-{1,2,3} to 3 @angular/* packages, with all 6 permutations (order-{a,b,c,d,e,f}). It turns out that only permutation d and f does reproduce the issue.

Expected Behavior

npm install should work, as versions are correct and peerDependencies are respected.

Steps To Reproduce

mkdir npmissue
cd npmissue
echo "@sarunint:registry=https://gitlab.com/api/v4/projects/28910102/packages/npm/" > .npmrc
npm init -y
npm install -E @sarunint/order-f-package-1@1.0.0 @sarunint/order-f-package-2@1.0.0 @sarunint/order-f-package-3@1.0.0 @sarunint/order-f-package-4@1.0.0
Replace 1.0.0 with 1.0.1 for only first 3 packages.
npm install: should fail with following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: npmissue@1.0.0
npm ERR! Found: @sarunint/order-f-package-1@1.0.0
npm ERR! node_modules/@sarunint/order-f-package-1
npm ERR!   @sarunint/order-f-package-1@"1.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! @sarunint/order-f-package-1@"1.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @sarunint/order-f-package-3@1.0.1
npm ERR! node_modules/@sarunint/order-f-package-3
npm ERR!   peer @sarunint/order-f-package-3@"1.0.1" from @sarunint/order-f-package-1@1.0.1
npm ERR!   node_modules/@sarunint/order-f-package-1
npm ERR!     @sarunint/order-f-package-1@"1.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/sarunint/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/sarunint/.npm/_logs/2021-08-19T19_47_04_754Z-debug.log

(You can try replace order-f with other variants. Only order-d and order-f will reproduce the issue.)

Environment

OS: Arch
Node: 14.17.5
npm: 7.21.0

The text was updated successfully, but these errors were encountered:

KristenLeach · 2021-09-14T22:58:12Z

I've updated npm to 7.23.0 and I am still seeing this error. Are there any updates?

brandones · 2021-10-07T02:02:12Z

The error is still present on 7.24.2. @sarunint 's reproduction is very easy to understand once you look at the code in the repository: https://gitlab.com/sarunint/npm-dependency-bug . Here's a diagram:

OrangeDog · 2021-10-07T15:07:47Z

I don't know if this is the same issue, but I appear to have a peer version of "*" being expanded into "0.0.0" and then failing?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @angular-eslint/eslint-plugin@2.1.1
npm ERR! Found: eslint-plugin-jsdoc@36.1.0
npm ERR! node_modules/eslint-plugin-jsdoc
npm ERR!   dev eslint-plugin-jsdoc@"^36.1.0" from the root project
npm ERR!   peer eslint-plugin-jsdoc@"*" from @angular-eslint/eslint-plugin@2.1.1
npm ERR!   node_modules/@angular-eslint/eslint-plugin
npm ERR!     dev @angular-eslint/eslint-plugin@"^2.1.1" from the root project
npm ERR!     @angular-eslint/eslint-plugin@"2.1.1" from @angular-eslint/schematics@2.1.1
npm ERR!     node_modules/@angular-eslint/schematics
npm ERR!       dev @angular-eslint/schematics@"^2.1.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-jsdoc@"*" from @angular-eslint/eslint-plugin@2.1.1
npm ERR! node_modules/@angular-eslint/eslint-plugin
npm ERR!   dev @angular-eslint/eslint-plugin@"^2.1.1" from the root project
npm ERR!   @angular-eslint/eslint-plugin@"2.1.1" from @angular-eslint/schematics@2.1.1
npm ERR!   node_modules/@angular-eslint/schematics
npm ERR!     dev @angular-eslint/schematics@"^2.1.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: eslint-plugin-jsdoc@0.0.0
npm ERR! node_modules/eslint-plugin-jsdoc
npm ERR!   peer eslint-plugin-jsdoc@"*" from @angular-eslint/eslint-plugin@2.1.1
npm ERR!   node_modules/@angular-eslint/eslint-plugin
npm ERR!     dev @angular-eslint/eslint-plugin@"^2.1.1" from the root project
npm ERR!     @angular-eslint/eslint-plugin@"2.1.1" from @angular-eslint/schematics@2.1.1
npm ERR!     node_modules/@angular-eslint/schematics
npm ERR!       dev @angular-eslint/schematics@"^2.1.1" from the root project

lukekarrys · 2021-10-08T03:09:23Z

Thanks for the thorough repro and explanation! This is definitely a bug, since it's a case npm should be able to resolve.

Another interesting thing I found when debugging this is that if I run the problematic install command with --force I get an identical package-lock.json as I get if I install them all at the same time. I'm going to dig into making this a test case in arborist so we can get this fixed.

echo "@sarunint:registry=https://gitlab.com/api/v4/projects/28910102/packages/npm/" > .npmrc

# reset everything
rm -rf node_modules/ package-lock.json package.json
npm init -y

# install the end result we want directly, this works
npm install -E @sarunint/order-f-package-1@1.0.1 @sarunint/order-f-package-2@1.0.1 @sarunint/order-f-package-3@1.0.1 @sarunint/order-f-package-4@1.0.0 --loglevel silly
cp package-lock.json this-was-successful.json

# reset everything again
rm -rf node_modules/ package-lock.json package.json
npm init -y

# install all 1.0.0
npm install -E @sarunint/order-f-package-1@1.0.0 @sarunint/order-f-package-2@1.0.0 @sarunint/order-f-package-3@1.0.0 @sarunint/order-f-package-4@1.0.0 --loglevel silly
# then install packages 1,2,3@1.0.1, but with force
npm install -E @sarunint/order-f-package-1@1.0.1 @sarunint/order-f-package-2@1.0.1 @sarunint/order-f-package-3@1.0.1 --force --loglevel silly
cp package-lock.json force.json

cmp this-was-successful.json force.json
# shows 0 since files are identical
echo $?

OrangeDog · 2021-10-08T09:27:52Z

And another, when attempting npm dedupe:

npm ERR! Conflicting peer dependency: typescript@4.4.3
npm ERR! node_modules/typescript
npm ERR!   peer typescript@"*" from @angular-eslint/builder@4.3.0
npm ERR!   node_modules/@angular-eslint/builder
npm ERR!     dev @angular-eslint/builder@"^4.3.0" from the root project

jpage-godaddy · 2021-11-17T20:50:51Z

Similar for me. There's a package def with a * version for jkl in peerDependencies, and despite the fact that a newer version of jkl is installed, the peerDependencies for the very earliest publish of jkl are being demanded. This is in npm@8.1.3.

» npm audit fix

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: my-app@0.1.0
npm ERR! Found: react-intl@4.7.6
npm ERR! node_modules/react-intl
npm ERR!   peer react-intl@"^4.5.3" from abc@2102.0.4
npm ERR!   node_modules/abc
npm ERR!     peer abc@">=2002.0.0" from def@4.18.4
npm ERR!     node_modules/def
npm ERR!       def@"^4.18.0" from the root project
npm ERR!       1 more (ghi)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react-intl@"^2.8.0" from jkl@2000.7.21
npm ERR! node_modules/jkl
npm ERR!   peer jkl@"*" from def@4.18.4
npm ERR!   node_modules/def
npm ERR!     def@"^4.18.0" from the root project
npm ERR!     1 more (ghi)

» npm ls jkl

my-app@0.1.0 /home/foo
└─┬ def@4.18.4
  └── jkl@2102.0.4

TrevorKarjanis · 2021-12-13T19:04:03Z

There are additional upstream reports with a similar failure in issues 21204 and 22365. This issue seems to be the closest I can find if they are indeed issues with npm. This time it errors reconciling @angular/compiler-cli@13.1.0 with @angular/compiler-cli@"^13.0.0 || ^13.1.0-next".

e1himself · 2021-12-14T10:24:00Z

I believe the issue I've reported here might be related too: #4104

kolkov · 2022-02-03T11:33:27Z

angular/angular#44959 one more related issue.
Can't update to 13.2.1 from 13.1.3 with Conflicting peer dependency: @angular/core@13.2.1

haskelcurry · 2022-04-11T09:46:28Z

Hi, any updates on this?

cklogs · 2022-04-28T04:55:25Z

Hi there,

This issue is still affecting Angular users. Can we perhaps get a status update?

XhmikosR · 2022-04-28T05:31:42Z

@lukekarrys did you have a chance to dig into this? It indeed affects angular and that's a lot of users. Would be nice if this was fixed. Using the npm version that ships with Node.js 16 LTS:

C:\Users\xmr\Desktop\repo>node -v && npm -v
v16.15.0
8.5.5

vugar005 · 2022-05-07T11:51:56Z

@cklogs @XhmikosR . For now, we can use --force flag. For example: npx @angular/cli@13 update @angular/core@13 @angular/cli@13 --force

BojanKogoj · 2022-05-18T08:36:55Z

We used --legacy-peer-deps (as suggested in error message) and it works this way for now.

Weerasinghe066 · 2023-04-25T09:13:41Z

I got that error when upgrading to angular version from 11 to version 12.
I changed the npm and node version and that's worked for me.
npm version - 6.14.16
node version - 12.22.12

fspreck-indiscale · 2023-05-11T12:06:38Z

The same happens with react@"^18.2.0" and "@testing-library/react": "^14.0.0":

npm ERR! Conflicting peer dependency: react@18.2.0
npm ERR! node_modules/react
npm ERR!   peer react@"^18.0.0" from @testing-library/react@14.0.0
npm ERR!   node_modules/@testing-library/react
npm ERR!     dev @testing-library/react@"^14.0.0" from the root project

npm: 9.6.6
node: v19.9.0

silvenon · 2024-04-29T22:26:35Z

The same issue is happening with npm v10.5.1 often with Remix dependencies, you should be able to reproduce this in a completely empty project. Mine were at version 2.8.0, and upgrading them results in the peer dependency errors:

npm i @remix-run/{express,node,react,dev,testing}@latest

npm ERR! Found: @remix-run/dev@2.8.0
npm ERR! node_modules/@remix-run/dev
npm ERR!   dev @remix-run/dev@"2.9.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @remix-run/dev@"2.9.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @remix-run/react@2.9.1
npm ERR! node_modules/@remix-run/react
npm ERR!   peer @remix-run/react@"^2.9.1" from @remix-run/dev@2.9.1
npm ERR!   node_modules/@remix-run/dev
npm ERR!     dev @remix-run/dev@"2.9.1" from the root project

What is it about these dependencies that makes it so hard for npm to resolve?

Additional info, if it matters:

Node v22.0.0
macOS 14.4.1

moshe-foreflight · 2024-12-26T14:46:32Z

Another example of this is a conflict between tree-sitter-swift and tree-sitter-objc. The former pins ^tree-sitter@0.21.1 and the latter ^tree-sitter@0.22.1.

There's an unexpected workaround here which is to first install tree-sitter-cli, using npm i tree-sitter-cli. I don't know enough about npm or the specific package implementations to understand why, but this seems to work.

Repro

brew install node;
mkdir tree-sitter-repro && cd tree-sitter-repro;
npm init -y;
npm i tree-sitter-objc;
npm i tree-sitter-swift;

Output: (2024-12-26T14_45_27_618Z-debug-0.log)

Environment

Node v23.5.0
NPM 10.9.2
macOS 14.5

sarunint added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Aug 19, 2021

brandones mentioned this issue Oct 7, 2021

[BUG] Can't install library with peerDependencies and devDependencies #3849

Closed

1 task

lukekarrys added Priority 1 high priority issue and removed Needs Triage needs review for next steps labels Oct 7, 2021

lukekarrys self-assigned this Oct 20, 2021

alextanlan mentioned this issue Jan 24, 2022

DDP-7226 PEX editor broadinstitute/ddp-angular#977

Merged

alan-agius4 mentioned this issue Jan 26, 2022

Unable to update from 13.1.0 to the latest point release angular/angular-cli#22565

Closed

15 tasks

alan-agius4 mentioned this issue Feb 3, 2022

Can't update to 13.2.1 from 13.1.3 with Conflicting peer dependency: @angular/core@13.2.1 angular/angular#44959

Closed

darcyclarke unassigned lukekarrys Feb 7, 2022

MichaelLangbein mentioned this issue Feb 18, 2022

Update angular and ukis riesgos/dlr-riesgos-frontend#71

Closed

alan-agius4 mentioned this issue Mar 10, 2022

Upgrade Angular 12 to 13 failing with peer dependency conflict angular/angular-cli#22826

Closed

lukekarrys mentioned this issue Apr 13, 2022

[BUG] non-previosly seen peer-dependency errors popping up in 8.6.0 #4664

Closed

2 tasks

ldez mentioned this issue Jun 5, 2022

build(deps): bump gatsby-plugin-mdx from 3.13.0 to 3.15.2 in /docs golangci/golangci-lint#2904

Merged

XhmikosR mentioned this issue Jun 8, 2022

[BUG] npm exits silently with the code 254 and read only filesystem #4838

Closed

2 tasks

tonivj5 mentioned this issue Nov 18, 2022

[BUG] Multiple related packages install fail due to wrong peerDependencies resolution #3083

Closed

dmitry-stepanenko mentioned this issue Mar 12, 2023

Dependency conflict after generating application in existing Nx repo qwikifiers/qwik-nx#106

Closed

dargmuesli mentioned this issue May 31, 2023

feat(typescript-urql-graphcache): mark @urql/exchange-graphcache v6 compatible dotansimha/graphql-code-generator-community#361

Merged

12 tasks

TrevorKarjanis mentioned this issue Nov 3, 2023

npm fails to resolve conditional dependencies ni/javascript-styleguide#131

Closed

This was referenced Dec 26, 2024

fyi: NPM Issue causes conflicting peerDependency with tree-sitter-swift. tree-sitter-grammars/tree-sitter-objc#19

Closed

fyi: npm bug manifesting as conflicting peerDependency version alex-pinkus/tree-sitter-swift#461

Open

silvenon mentioned this issue Dec 27, 2024

[BUG] Peer dependency warnings are never seen when using legacy-peer-deps #6227

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] Multiple related packages install fail due to wrong peerDependencies resolution #3666

[BUG] Multiple related packages install fail due to wrong peerDependencies resolution #3666

sarunint commented Aug 19, 2021 •

edited

Loading

KristenLeach commented Sep 14, 2021

brandones commented Oct 7, 2021

OrangeDog commented Oct 7, 2021 •

edited

Loading

lukekarrys commented Oct 8, 2021

OrangeDog commented Oct 8, 2021

jpage-godaddy commented Nov 17, 2021 •

edited

Loading

TrevorKarjanis commented Dec 13, 2021

e1himself commented Dec 14, 2021

kolkov commented Feb 3, 2022 •

edited

Loading

haskelcurry commented Apr 11, 2022

cklogs commented Apr 28, 2022

XhmikosR commented Apr 28, 2022

vugar005 commented May 7, 2022 •

edited

Loading

BojanKogoj commented May 18, 2022

Weerasinghe066 commented Apr 25, 2023

fspreck-indiscale commented May 11, 2023

silvenon commented Apr 29, 2024 •

edited

Loading

moshe-foreflight commented Dec 26, 2024

[BUG] Multiple related packages install fail due to wrong peerDependencies resolution #3666

[BUG] Multiple related packages install fail due to wrong peerDependencies resolution #3666

Comments

sarunint commented Aug 19, 2021 • edited Loading

Is there an existing issue for this?

Current Behavior

Expected Behavior

Steps To Reproduce

Environment

KristenLeach commented Sep 14, 2021

brandones commented Oct 7, 2021

OrangeDog commented Oct 7, 2021 • edited Loading

lukekarrys commented Oct 8, 2021

OrangeDog commented Oct 8, 2021

jpage-godaddy commented Nov 17, 2021 • edited Loading

TrevorKarjanis commented Dec 13, 2021

e1himself commented Dec 14, 2021

kolkov commented Feb 3, 2022 • edited Loading

haskelcurry commented Apr 11, 2022

cklogs commented Apr 28, 2022

XhmikosR commented Apr 28, 2022

vugar005 commented May 7, 2022 • edited Loading

BojanKogoj commented May 18, 2022

Weerasinghe066 commented Apr 25, 2023

fspreck-indiscale commented May 11, 2023

silvenon commented Apr 29, 2024 • edited Loading

moshe-foreflight commented Dec 26, 2024

Repro

Environment

sarunint commented Aug 19, 2021 •

edited

Loading

OrangeDog commented Oct 7, 2021 •

edited

Loading

jpage-godaddy commented Nov 17, 2021 •

edited

Loading

kolkov commented Feb 3, 2022 •

edited

Loading

vugar005 commented May 7, 2022 •

edited

Loading

silvenon commented Apr 29, 2024 •

edited

Loading