Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fyi: NPM Issue causes conflicting peerDependency with tree-sitter-swift. #19

Closed
2 tasks done
moshe-foreflight opened this issue Dec 26, 2024 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@moshe-foreflight
Copy link

Did you check existing issues?

  • I have read all the tree-sitter docs if it relates to using the parser
  • I have searched the existing issues

Tree-Sitter CLI Version, if relevant (output of tree-sitter --version)

tree-sitter 0.24.5

Describe the bug

Installation alongside tree-sitter-swift fails, reporting a conflicting peerDependency version for the tree-sitter dependency.

This is likely due to this bug in npm. Reporting here because I've been able to work around this issue by installing tree-sitter-cli. (No idea why this works.)

Steps To Reproduce/Bad Parse Tree

  1. npm install tree-sitter-swift
  2. npm install tree-sitter-objc

Expected Behavior/Parse Tree

Installation of the package should succeed.

Repro

brew install node;
mkdir tree-sitter-repro && cd tree-sitter-repro;
npm init -y;
npm i tree-sitter-swift;
npm i tree-sitter-objc;

This will fail.

If we run npm i tree-sitter-cli and try again, then npm i tree-sitter-objc succeeds.

@moshe-foreflight moshe-foreflight added the bug Something isn't working label Dec 26, 2024
@moshe-foreflight moshe-foreflight changed the title fyi: NPM Issue causes failure on conflicting peerDependency with tree-sitter-swift. fyi: NPM Issue causes conflicting peerDependency with tree-sitter-swift. Dec 26, 2024
@amaanq
Copy link
Member

amaanq commented Dec 26, 2024

tell swift to upgrade

@amaanq amaanq closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
@moshe-foreflight
Copy link
Author

Yep, already did.

alex-pinkus/tree-sitter-swift#461 (comment)

There's got to be a better way to keep these NPM packages in sync, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants