-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] npm ci
doesn't exit when dependencies in lockfile do not match the package.json
#3947
Closed
1 task done
Labels
Comments
koenpunt
added
Bug
thing that needs fixing
Needs Triage
needs review for next steps
Release 8.x
work is associated with a specific npm 8 release
labels
Oct 27, 2021
PiDelport
added a commit
to ntls-io/nautilus-wallet
that referenced
this issue
Oct 27, 2021
Upstream issue: * npm/cli#3947
The following check can work around this, in the meantime: npm install
git diff --exit-status |
PiDelport
added a commit
to ntls-io/nautilus-wallet
that referenced
this issue
Oct 27, 2021
* ci(web-client): work around "npm ci" being broken Upstream issue: * npm/cli#3947 * chore(web-client): sync package-lock.json
This issue already exists in #2701 Thanks for the work around, might consider it |
2 tasks
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this issue
Feb 3, 2022
Make sure to validate any lock file (either package-lock.json or npm-shrinkwrap.json) against the current install. This will properly throw an error in case any of the dependencies being installed don't match the dependencies that are currently listed in the lock file. Fixes: npm#2701 Fixes: npm#3947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is there an existing issue for this?
Current Behavior
When the
package.json
was updated with new dependencies, and the lockfile isn't,npm ci
successfully installs the dependencies.Expected Behavior
According to the documentation
npm ci
should exit when there's a discrepancy between thepackage.json
and the lockfile.Steps To Reproduce
npm init -f && npm install
package.json
, but don't update thepackage-lock.json
;npm ci
Environment
The text was updated successfully, but these errors were encountered: