Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm error Exit handler never called exits with status code 0 #7672

Closed
2 tasks done
Sebastian-Webster opened this issue Jul 19, 2024 · 7 comments · Fixed by #7674 or GulajavaMinistudio/cli#123
Closed
2 tasks done
Assignees
Labels
Bug thing that needs fixing Priority 1 high priority issue

Comments

@Sebastian-Webster
Copy link

Sebastian-Webster commented Jul 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

This issue, related to #7666 and #7669, exits with status code 0 when the exit handler npm error occurs. Exiting with status code 0 allows the ci to continue to the next steps.

Expected Behavior

I would expect it to exit with status code 1 since it is an error. That way ci would fail when this error occurs.

Steps To Reproduce

The GitHub Actions workflow showing this behaviour can be found at: https://github.com/Sebastian-Webster/npm-reproducible-example/actions/runs/10007253675
The repository code for that workflow can be found here at: https://github.com/Sebastian-Webster/npm-reproducible-example/tree/22.5.0
This example shows that the issue does not happen in Node 22.4.1, but does in 22.5.0.

Environment

  • npm: v10.8.2
  • Node.js: v22.5.0
  • OS Name: Windows 2019 & 2022, macOS 12, 13, & 14, and Ubuntu 20.04 & Ubuntu 22.04
  • System Model Name: GitHub Actions
@avivkeller

This comment has been minimized.

@AmalendhuKR

This comment has been minimized.

@wraithgar

This comment has been minimized.

@wraithgar
Copy link
Member

Didn't see that this had to do w/ the exit code. Yes, the underlying problem causing the early exit was fixed. The fact that npm does not exit w/ status code 1 is a separate problem.

@wraithgar wraithgar added Priority 1 high priority issue and removed Needs Triage needs review for next steps labels Jul 19, 2024
@wraithgar wraithgar self-assigned this Jul 19, 2024
@gabriel-piltzer-trimble

This comment has been minimized.

@Sebastian-Webster

This comment has been minimized.

shiomiyan added a commit to shiomiyan/blog that referenced this issue Jul 19, 2024
@danielhjacobs

This comment was marked as off-topic.

Apollon77 added a commit to ioBroker/ioBroker.matter that referenced this issue Jul 20, 2024
james-pre added a commit to zen-fs/core that referenced this issue Jul 20, 2024
commenthol added a commit to commenthol/debug-level that referenced this issue Jul 21, 2024
upgrade to use actions/checkout@v4
removing node@22 due to issue npm/cli#7672
Apollon77 added a commit to ioBroker/ioBroker.matter that referenced this issue Jul 21, 2024
* Add Prettier

* see npm/cli#7672

* review feedback

* review feedback
mceachen added a commit to photostructure/exiftool-vendored.js that referenced this issue Jul 21, 2024
wraithgar added a commit that referenced this issue Jul 29, 2024
An erroneous assumption was that if this was explicitly set, then the
exit was still intentional. This is not the case.

Closes: #7672

---------

Co-authored-by: Chris Sidi <hashtagchris@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Priority 1 high priority issue
Projects
None yet
6 participants