-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] npm error Exit handler never called exits with status code 0 #7672
Closed
2 tasks done
Sebastian-Webster opened this issue
Jul 19, 2024
· 7 comments
· Fixed by #7674 or GulajavaMinistudio/cli#123
Closed
2 tasks done
[BUG] npm error Exit handler never called exits with status code 0 #7672
Sebastian-Webster opened this issue
Jul 19, 2024
· 7 comments
· Fixed by #7674 or GulajavaMinistudio/cli#123
Labels
Comments
Sebastian-Webster
added
Bug
thing that needs fixing
Needs Triage
needs review for next steps
labels
Jul 19, 2024
2 tasks
2 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7 tasks
Didn't see that this had to do w/ the exit code. Yes, the underlying problem causing the early exit was fixed. The fact that npm does not exit w/ status code 1 is a separate problem. |
wraithgar
added
Priority 1
high priority issue
and removed
Needs Triage
needs review for next steps
labels
Jul 19, 2024
This comment has been minimized.
This comment has been minimized.
CactusPuppy
added a commit
to CactusPuppy/overpy
that referenced
this issue
Jul 19, 2024
This comment has been minimized.
This comment has been minimized.
shiomiyan
added a commit
to shiomiyan/blog
that referenced
this issue
Jul 19, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Apollon77
added a commit
to ioBroker/ioBroker.matter
that referenced
this issue
Jul 20, 2024
james-pre
added a commit
to zen-fs/core
that referenced
this issue
Jul 20, 2024
commenthol
added a commit
to commenthol/debug-level
that referenced
this issue
Jul 21, 2024
upgrade to use actions/checkout@v4 removing node@22 due to issue npm/cli#7672
Apollon77
added a commit
to ioBroker/ioBroker.matter
that referenced
this issue
Jul 21, 2024
* Add Prettier * see npm/cli#7672 * review feedback * review feedback
mceachen
added a commit
to photostructure/exiftool-vendored.js
that referenced
this issue
Jul 21, 2024
wraithgar
added a commit
that referenced
this issue
Jul 29, 2024
An erroneous assumption was that if this was explicitly set, then the exit was still intentional. This is not the case. Closes: #7672 --------- Co-authored-by: Chris Sidi <hashtagchris@github.com>
james-pre
added a commit
to zen-fs/core
that referenced
this issue
Sep 16, 2024
This reverts commit a6287a9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
This issue exists in the latest npm version
Current Behavior
This issue, related to #7666 and #7669, exits with status code 0 when the exit handler npm error occurs. Exiting with status code 0 allows the ci to continue to the next steps.
Expected Behavior
I would expect it to exit with status code 1 since it is an error. That way ci would fail when this error occurs.
Steps To Reproduce
The GitHub Actions workflow showing this behaviour can be found at: https://github.com/Sebastian-Webster/npm-reproducible-example/actions/runs/10007253675
The repository code for that workflow can be found here at: https://github.com/Sebastian-Webster/npm-reproducible-example/tree/22.5.0
This example shows that the issue does not happen in Node 22.4.1, but does in 22.5.0.
Environment
The text was updated successfully, but these errors were encountered: