Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cookie module SameSite: None #997

Closed
erbek opened this issue Mar 10, 2020 · 3 comments
Closed

[BUG] cookie module SameSite: None #997

erbek opened this issue Mar 10, 2020 · 3 comments
Labels
Bug thing that needs fixing

Comments

@erbek
Copy link

erbek commented Mar 10, 2020

What / Why

Hello team
There is no handling of SameSite: 'none'. Please add it as it's required according to new Chrome security policy.

When

Where

node_modules/cookie/index.js:
Line 173:
case 'none':
str += '; SameSite=None';
break;

@ljharb
Copy link
Contributor

ljharb commented Mar 10, 2020

@erbek this is npm's repo; you want https://github.com/jshttp/cookie

@erbek
Copy link
Author

erbek commented Mar 10, 2020 via email

@darcyclarke darcyclarke added the Bug thing that needs fixing label Oct 30, 2020
@darcyclarke
Copy link
Contributor

npm v6 is no longer in active development; We will continue to push security releases to v6 at our team's discretion as-per our Support Policy.

If your bug is preproducible on v7, please re-file this issue using our new issue template.

If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo

Closing: This is an automated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing
Projects
None yet
Development

No branches or pull requests

3 participants