Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace var with const/let in repo #119

Merged
merged 1 commit into from
Jan 9, 2019
Merged

chore: replace var with const/let in repo #119

merged 1 commit into from
Jan 9, 2019

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Dec 14, 2018

@watilde watilde requested a review from a team as a code owner December 14, 2018 20:39
@watilde watilde changed the title chore: replace var with const/let chore: replace var with const/let in repo Dec 14, 2018
@zkat
Copy link
Contributor

zkat commented Dec 14, 2018

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

@watilde
Copy link
Contributor Author

watilde commented Dec 15, 2018

I just splitted into the two here and #120.

aeschright
aeschright approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@aeschright aeschright changed the base branch from latest to release-next January 9, 2019 22:06
@aeschright aeschright merged commit 73a3edf into npm:release-next Jan 9, 2019
aeschright pushed a commit that referenced this pull request Jan 10, 2019
@watilde
chore: replace var with const/let in lib/repo.js (#119)
c665f35 
PR-URL: #119
Credit: @watilde 
Reviewed-By: @aeschright
aeschright added a commit that referenced this pull request Jan 10, 2019
@aeschright
Revert "chore: replace var with const/let in lib/repo.js (#119)"
0bd6291 
This reverts commit c665f35.
aeschright pushed a commit that referenced this pull request Jan 18, 2019
@watilde @aeschright
chore: replace var with const/let in lib/repo.js (#119)
255d69b 
PR-URL: #119
Credit: @watilde 
Reviewed-By: @aeschright
@watilde watilde deleted the feature/let-const branch December 2, 2019 17:06
@kevinjm39 kevinjm39 mentioned this pull request May 1, 2022
Open
@CALISOULB CALISOULB mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Open
@bumplzz69 bumplzz69 mentioned this pull request Nov 30, 2023
Open
@mtdev2 mtdev2 mentioned this pull request Nov 30, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Nov 30, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Nov 30, 2023
Open
@baby636 baby636 mentioned this pull request Dec 1, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Dec 1, 2023
Open
@MrBrain295 MrBrain295 mentioned this pull request Dec 19, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watilde @zkat @aeschright