Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: npm@6.2.0 #12

Merged
merged 58 commits into from
Jul 14, 2018
Merged

release: npm@6.2.0 #12

merged 58 commits into from
Jul 14, 2018

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Jul 13, 2018

zkat and others added 30 commits May 24, 2018 14:36
This fixes the regular expression matching in `xcode_emulation`
to also handle version numbers with multiple-digit major versions
which would otherwise break under use of XCode 10

Fixes: nodejs/node-gyp#1454
PR-URL: npm/npm#20948
Credit: @Trott
Reviewed-By: @zkat
@zkat zkat requested a review from a team as a code owner July 13, 2018 17:46
@ljharb
Copy link
Contributor

ljharb commented Jul 13, 2018

the changelog link doesn't seem to point anywhere?

@zkat
Copy link
Contributor Author

zkat commented Jul 13, 2018

@ljharb lmao sorry. I forgot to fill it in after I posted the PR. Fixed 👍

Copy link
Contributor

@iarna iarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@zkat zkat merged commit ab3c62a into latest Jul 14, 2018
@zkat
Copy link
Contributor Author

zkat commented Jul 14, 2018

@rarkins

➜ npm view npm@latest repository
{ type: 'git', url: 'git+https://github.com/npm/cli.git' }

It seems to be fine now.

@rarkins
Copy link

rarkins commented Jul 14, 2018

@zkat I was meaning to reference the top-level field, e.g.

❯ curl --silent https://registry.npmjs.org/npm | jq -r '.repository'
{
  "type": "git",
  "url": "git+https://github.com/npm/npm.git"
}

This is what I have been using until now as the definitive source repository for a package.

Is there any reason why/when this shouldn't match exactly with the repository object inside the latest version?

antongolub pushed a commit to antongolub-forks/npm-cli that referenced this pull request May 18, 2024
This uses the updated version of gentle-fs which has the binLink method,
so that we don't need to fork based on OS, and will always check to
ensure that the bin or cmd-shim is a reference into the folder being
linked.

Also perform a similar check on linked man pages.

Fix npm#11

PR-URL: npm/bin-links#12
Credit: @isaacs
Close: npm#12
Reviewed-by: @isaacs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.