Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: maketest: Fix common.npm callback arguments #144

Merged
merged 1 commit into from
Jan 29, 2019
Merged

test: maketest: Fix common.npm callback arguments #144

merged 1 commit into from
Jan 29, 2019

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Jan 19, 2019

See

cli/test/common-tap.js

Line 56 in bb8688d

return resolve([code, stdout, stderr])

@larsgw larsgw requested a review from a team as a code owner January 19, 2019 16:52
@aeschright aeschright added the semver:minor new backwards-compatible feature label Jan 22, 2019
iarna
iarna approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@iarna iarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐑

@zkat zkat force-pushed the release-next branch 2 times, most recently from db63b89 to b09bc8c Compare January 23, 2019 18:36
zkat
zkat approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Please go ahead and re-rebase to get rid of the 6.7.0 changelog patch, and this is otherwise fine. Thanks again!

@aeschright aeschright merged commit cdb0592 into npm:release-next Jan 29, 2019
aeschright pushed a commit that referenced this pull request Feb 14, 2019
@larsgw @aeschright
test(maketest): Fix common.npm callback arguments (#144)
75dce4c 
PR-URL: #144
Credit: @larsgw
Reviewed-By: @aeschright
@Mhmonicox Mhmonicox mentioned this pull request Feb 15, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Jun 1, 2023
Open
@MrBrain295 MrBrain295 mentioned this pull request Oct 29, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Oct 29, 2023
Open
@311821105 311821105 mentioned this pull request Nov 26, 2023
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Nov 27, 2023
Open
@TheManager73 TheManager73 mentioned this pull request Nov 28, 2023
Open
@gutwrinch gutwrinch mentioned this pull request Nov 28, 2023
Merged
@kingjay66 kingjay66 mentioned this pull request Nov 29, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Nov 29, 2023
Open
@kevinjm39 kevinjm39 mentioned this pull request Nov 30, 2023
Open
@LadyK-21 LadyK-21 mentioned this pull request Nov 30, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Nov 30, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Nov 30, 2023
Open
@adamlaska adamlaska mentioned this pull request Nov 30, 2023
Open
@soloinovator soloinovator mentioned this pull request Nov 30, 2023
Open
@bumplzz69 bumplzz69 mentioned this pull request Nov 30, 2023
Open
@mtdev2 mtdev2 mentioned this pull request Nov 30, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Nov 30, 2023
Open
@soloinovator soloinovator mentioned this pull request Feb 11, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Feb 11, 2024
Open
@Mary12jo33 Mary12jo33 mentioned this pull request Feb 11, 2024
Open
@LadyK-21 LadyK-21 mentioned this pull request Feb 11, 2024
Open
@CALISOULB CALISOULB mentioned this pull request Feb 11, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Feb 11, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 11, 2024
Open
This was referenced Feb 11, 2024
Open
Open
This was referenced Feb 11, 2024
Open
Open
@jackromo888 jackromo888 mentioned this pull request Feb 11, 2024
Open
This was referenced Feb 11, 2024
Open
Open
Open
@f4lco0n f4lco0n mentioned this pull request Feb 11, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 11, 2024
Open
@adamlaska adamlaska mentioned this pull request Feb 11, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 11, 2024
Open
@311821105 311821105 mentioned this pull request Feb 12, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Feb 12, 2024
Open
@kingjay66 kingjay66 mentioned this pull request Feb 12, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Feb 12, 2024
Open
@LadyK-21 LadyK-21 mentioned this pull request Feb 12, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Feb 12, 2024
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Feb 12, 2024
Open
@adamlaska adamlaska mentioned this pull request Feb 12, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Feb 12, 2024
Open
@TheManager73 TheManager73 mentioned this pull request Feb 12, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iarna iarna iarna approved these changes

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
semver:minor new backwards-compatible feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larsgw @zkat @iarna @aeschright