refactor lib npm.js #1509
Closed
refactor lib npm.js #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
from
bbabed3
to
d71db29
Compare
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
2 times, most recently
from
455721f
to
0350ae5
Compare
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
from
0350ae5
to
41f9a40
Compare
|
@isaacs given the new default for |
Also, modernize the code in the unsupported version checking module.
Allows openUrl to open `file://` urls, and passes that instead of the raw path.
We don't use that any more, Arborist handles it all for us.
- Several sections of code moved out into separate modules. - npm is an instance of an inline class. - uses a Proxy for npm.commands object instead of the old hand-rolled Proxy-esque thing. - organized code path for outputting usage/help information.
This removes a lot of very outdated dependencies, updates many to their modern (usually promisified) versions, and updates (or removes) code to account for the change. Several dependencies have been completely removed, and others a bit shuffled around, so that the node_modules folder can be bundled somewhat more optimally than it would have otherwise.
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
from
732c0cd
to
c97a878
Compare
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
from
b371225
to
96d0f25
Compare
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
from
e69258b
to
4905fa8
Compare
This resets the node_modules tree state after fixing the bug in minipass-pipeline that caused some tarballs to be incompletely unpacked.
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
from
b7fd350
to
d6755f0
Compare
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
5 times, most recently
from
b518fae
to
a576bca
Compare
isaacs
force-pushed
the
isaacs/refactor-lib-npm.js
branch
from
a576bca
to
ed5c7dc
Compare
isaacs
added a commit
that referenced
this pull request
Jul 29, 2020
PR-URL: #1509 Credit: @isaacs Close: #1509 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up
lib/npm.js,lib/help.js,bin/npm-cli.js, and creating 100% test coverage along the way.Come and get it! Packed full of refactoring and shiny new unit tests.