Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full integrity to pack's debug output #1534

Closed
wants to merge 1 commit into from
Closed

Add full integrity to pack's debug output #1534

wants to merge 1 commit into from

Conversation

cookieguru
Copy link

What / Why

This will add the full integrity to the debug output. The existing output only logs a partial version to notice:

cli/lib/pack.js

Line 201 in 66092d5

value: tarball.integrity.toString().substr(0, 20) + '[...]' + tarball.integrity.toString().substr(80)},

@cookieguru cookieguru requested a review from a team as a code owner July 18, 2020 18:37
@ruyadorno
Copy link
Contributor

Hi @cookieguru thanks for your contribution 😄

Unfortunately with our focus switching to npm7, changes to the current npm6 release line are going to be limited to critical fixes for security issues and major bugs only.

This change sounds like it might be semver-minor worthy so if you want to see it happen it might be a better idea to retarget it to the release/v7.0.0-beta branch. Feel free to reopen this PR targeting v7 or open a new one if you're interested in following up.

Thanks again and all the best! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants