Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: update lock before lifecycle #171

Closed
wants to merge 1 commit into from

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Mar 5, 2019

Update version information in lock files before the main version
lifecycle script is run.

See https://npm.community/t/5135


Should probably include tests but that seems to require refactoring that particular test setup and I don't feel like doing that right now and I though, let's discuss the changes first.

Also, I couldn't run the existing tests because they failed when run as a bunch but passed while run individually. Then they edited this very commit (?!), so I'm just going to let Travis-CI handle this.

Update version information in lock files before the main `version` 
lifecycle script is run.

See https://npm.community/t/5135
@larsgw larsgw requested a review from a team as a code owner March 5, 2019 22:08
@zkat zkat added semver:major backwards-incompatible breaking changes needs-tests labels Mar 6, 2019
@isaacs isaacs force-pushed the release-next branch 2 times, most recently from 896149d to 31718e7 Compare June 29, 2019 21:55
@settings settings bot removed the needs-tests label Nov 5, 2019
@darcyclarke
Copy link
Contributor

@larsgw sorry for the delay here. We now do this in npm v7. Closing this but appreciate the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major backwards-incompatible breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants