-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix doctor test to work correctly for node pre-release versions #2358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
approved these changes
Dec 15, 2020
|
darcyclarke
added
Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
labels
Dec 16, 2020
MylesBorins
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Dec 16, 2020
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 17, 2020
Refs: npm/cli#2358 PR-URL: #36543 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
isaacs
pushed a commit
that referenced
this pull request
Dec 18, 2020
PR-URL: #2358 Credit: @nlf Close: #2358 Reviewed-by: @ruyadorno Reviewed-by: @MylesBorins
isaacs
force-pushed
the
nlf/fix-doctor-tests
branch
from
December 18, 2020 19:19
edad2b9
to
628a554
Compare
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 21, 2020
Refs: npm/cli#2358 PR-URL: #36543 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: next
These items should be addressed in the next release
Release 7.x
work is associated with a specific npm 7 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running tests against nodejs
v16.0.0-pre
the existing test would fail, i tweaked the test so that it will work correctly for pre-release versions