-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't override user specified depth in outdated #239
Conversation
Restores ability to update packages using `--depth` as suggested by `npm audit`. i.e `npm update eslint-utils --depth 2`.
I came across another PR related to infinity regressions which casts a little light on the original use of the infinity magic value to have different default behaviours in different commands: npm/npm#11726 (And like @G-Rath, not sure if that value is still relevant!) |
Thanks, this is definitely a bug. |
https://docs.npmjs.com/misc/config#depth
|
* Add a lint:deps job to the top-level package.json, so lerna can run lint:deps in all packages in parallel. * Also fix today's handlebars vulnerability, so that builds don't fail. Some of the vulnerabilities are in transitive dependencies, yet the suggested `npm update foo --depth N` command sometimes seems to do nothing. There was a related bug in npm 6.6.0 - 6.11.2, fixed by npm/cli#239, but perhaps that didn't fix all the cases? As a workaround, I've added exceptions where npm wasn't able to fixup vulnerabilities. Fixes #2229.
* Add a lint:deps job to the top-level package.json, so lerna can run lint:deps in all packages in parallel. * Also fix today's handlebars vulnerability, so that builds don't fail. Some of the vulnerabilities are in transitive dependencies, yet the suggested `npm update foo --depth N` command sometimes seems to do nothing. There was a related bug in npm 6.6.0 - 6.11.2, fixed by npm/cli#239, but perhaps that didn't fix all the cases? (I was using npm 6.12.0.) As a workaround, I've added audit-filter exceptions where `npm update` wasn't able to fix vulnerabilities. Fixes #2229.
* Add a lint:deps job to the top-level package.json, so lerna can run lint:deps in all packages in parallel. * Also fix today's handlebars vulnerability, so that builds don't fail. Some of the vulnerabilities are in transitive dependencies, yet the suggested `npm update foo --depth N` command sometimes seems to do nothing. There was a related bug in npm 6.6.0 - 6.11.2, fixed by npm/cli#239, but perhaps that didn't fix all the cases? (I was using npm 6.12.0.) As a workaround, I've added audit-filter exceptions where `npm update` wasn't able to fix vulnerabilities. Fixes #2229.
Seem to be experiencing this in npm
Update |
* Add a lint:deps job to the top-level package.json, so lerna can run lint:deps in all packages in parallel. * Also handle recent handlebars vulnerability, so that builds don't fail. * Note, the lint:deps job is a no-op in fxa-amplitude-send, as I can't get it to build yet in the monorepo. Some of the vulnerabilities are in transitive dependencies, yet the suggested `npm update foo --depth N` command sometimes seems to do nothing. There was a related bug in npm 6.6.0 - 6.11.2, fixed by npm/cli#239, but perhaps that didn't fix all the cases? (I was using npm 6.12.0.) As a workaround, I've added audit-filter exceptions where `npm update` wasn't able to fix vulnerabilities. Fixes #2229.
* Add a lint:deps job to the top-level package.json, so lerna can run lint:deps in all packages in parallel. * Also handle recent handlebars vulnerability, so that builds don't fail. * Note, the lint:deps job is a no-op in fxa-amplitude-send, as I can't get it to build yet in the monorepo. Some of the vulnerabilities are in transitive dependencies, yet the suggested `npm update foo --depth N` command sometimes seems to do nothing. There was a related bug in npm 6.6.0 - 6.11.2, fixed by npm/cli#239, but perhaps that didn't fix all the cases? (I was using npm 6.12.0.) As a workaround, I've added audit-filter exceptions where `npm update` wasn't able to fix vulnerabilities. Fixes #2229.
* Add a lint:deps job to the top-level package.json, so lerna can run lint:deps in all packages in parallel. * Also handle recent handlebars vulnerability, so that builds don't fail. * Note, the lint:deps job is a no-op in fxa-amplitude-send, as I can't get it to build yet in the monorepo. Some of the vulnerabilities are in transitive dependencies, yet the suggested `npm update foo --depth N` command sometimes seems to do nothing. There was a related bug in npm 6.6.0 - 6.11.2, fixed by npm/cli#239, but perhaps that didn't fix all the cases? (I was using npm 6.12.0.) As a workaround, I've added audit-filter exceptions where `npm update` wasn't able to fix vulnerabilities. Fixes #2229.
Restores ability to update packages using
--depth
as suggested bynpm audit
.i.e
npm update eslint-utils --depth 2
.I've restored the previous conditional check, which was against
Infinity
; however I've never worked innpm/cli
before, so don't know if that value still holds water :)How it is currently means the
npm update <package> --depth <depth>
commands suggested bynpm audit
won't work, as anydepth
value is clobbered to0
if it's anything but, resulting in empty output.This is the related community bug report.
Since this was included in v6.6.0 onwards, it effects all versions of Node from
11.10.0
onwards, as well as10.16.0+