Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up flaky tests #240

Closed
wants to merge 1 commit into from
Closed

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Aug 26, 2019

  1. Get rid of a lot of usage of osenv.tmpdir in tests.
  2. Remove unnecessary creation/deletion of common.pkg
  3. Reduce rimraf.sync wherever possible (often collides with common-tap.js's rimraf on windows)
  4. Use common test utilities wherever possible.
  5. DRY tests with test templates where it makes sense.

@isaacs isaacs requested a review from a team as a code owner August 26, 2019 16:15
@isaacs isaacs force-pushed the isaacs/more-flaky-test-cleanup branch 2 times, most recently from e9fd192 to c7c7753 Compare August 28, 2019 22:58
@isaacs isaacs changed the title WIP DO NOT MERGE: clean up flaky tests clean up flaky tests Aug 28, 2019
@isaacs
Copy link
Contributor Author

isaacs commented Aug 28, 2019

Ok, this is ready to review now.

@darcyclarke
Copy link
Contributor

This looks like a fairly large diff so it may take a second or two to go through; I'm also finishing up a couple other tasks atm but definitely want to give this some <3

Hopefully @billatnpm will have a couple extra cycles over the next couple days to review as well.

@darcyclarke darcyclarke modified the milestone: v6.11.4 Sep 10, 2019
* Get rid of a lot of usage of osenv.tmpdir in tests.
* Remove unnecessary creation/deletion of common.pkg
* Reduce rimraf.sync wherever possible (often collides with
  common-tap.js's rimraf on windows)
* Use common test utilities wherever possible.
* DRY tests with test templates where it makes sense.
@isaacs isaacs force-pushed the isaacs/more-flaky-test-cleanup branch from c7c7753 to 2f7ec52 Compare October 31, 2019 18:42
@ruyadorno ruyadorno mentioned this pull request Oct 31, 2019
@ruyadorno ruyadorno closed this in 9a2d8af Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants