Release 6.12.0 #264
Merged
Release 6.12.0 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: filter functions and undefined out of makeEnv (@isaacs)
- fix: pack git directories properly (@claudiahdz) - respect no-optional argument (@cruzdanilo)
PR-URL: #252 Credit: @claudiahdz Close: #252 Reviewed-by: @mikemimik
It seems that a couple of lines were missed when token.js was [changed to use figgyPudding][1] which [causes an error][2] when trying to run that command in certain circumstances. This patch fixes that error. [1]: 4cf850d#diff-398ed3b014436a5204583323ea29320b [2]: https://npm.community/t/npm-token-err-figgypudding-options-cannot-be-modified-use-concat-instead/10288 PR-URL: #259 Credit: @benblank Close: #259 Reviewed-by: @isaacs
- Fixed setting engine check warnings to each package - Added proper catching of package warnings during validation phase - Added tap test that validates print of engine warn msgs Fix: https://npm.community/t/engines-and-engines-strict-ignored/4792 PR-URL: #257 Credit: @ruyadorno Close: #257 Reviewed-by: @isaacs
Pushing back a week to fix some bugs that have been found. - Engine check warnings get written to package.json, resulting in weird behavior later. - GitLab URL parsing needs a bit more tweaks to handle urls like /user/repo/repository/ref/archive.tar.gz
Currently all of our tests verify on teardown that there are no
root-owned files in the cache.
However, owing to some race conditions and slippery stream event
deferral behavior that won't be fixed until v7, occasionally cacache's
chown doesn't get processed until _after_ the promise resolves and the
test ends.
As a result, sometimes this check occurs before the chown has happened,
resulting in flaky hard-to-reproduce failures.
The somewhat-kludgey solution here is to move the ownership check from
t.teardown to process.on('exit'). In npm v7, we should move it back to
t.teardown, because we should never have a test that resolves in such a
way as to leave the cache in an invalid state.
PR-URL: #262
Credit: @isaacs
Close: #262
Reviewed-by: @isaacs
PR-URL: #257 Credit: @ruyadorno Close: #257 Reviewed-by: @isaacs
|
I've just upgraded to 6.12.0, but prepare scripts for git dependencies are still not run on |
|
@herrernst Do you have an example that you can share? There is a chance that a hard cache reset can solve the problem (just judging from someone else's experience who was running into this). |
|
Thanks, after removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.12.0 (2019-10-08):
Now
npm ciruns prepare scripts for git dependencies, and respects the--no-optionalargument. Warnings forenginemismatches are printed again. Various other fixes and cleanups.BUG FIXES
890b245dc#252 ci: add dirPacker to options (@claudiahdz)f3299acd0#257 npm.community#4792 warn message on engine mismatch (@ruyadorno)bbc92fb8f#259 npm.community#10288 Fix figgyPudding error innpm token(@benblank)70f54dcb5#241 doctor: Make OK more consistent (@gemal)FEATURES
ed993a29c#249 Add CI environment variables to user-agent (@isaacs)f6b0459a4#248 Add option to save package-lock without formatting Adds a new config--format-package-lock, which defaults to true. (@bl00mber)DEPENDENCIES
0ca063c5dnpm-lifecycle@3.1.4:5df6b0ea2libcipm@4.0.4:7e04f728ctar@4.4.125c380e5a3stringify-package@1.0.1(@isaacs)62f2ca692node-gyp@5.0.5(@isaacs)0ff0ea47anpm-install-checks@3.0.2(@isaacs)f46edae94hosted-git-info@2.8.5(@isaacs)TESTING
44a2b036b#262 fix root-ownership race conditions in meta-test (@isaacs)