-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unsupported: add node v13 #269
Conversation
Note to @npm/cli-team: we can make this file a lot simpler in npm v7 when we upgrade to a version of semver with the |
Why would that option matter? node 13 could probably have been added prior to its release, it just might not have been counted as "supported" then? |
yay, tests passed! how soon might this be able to get into a released version of npm? |
as soon as this lands on master I can make a backport to node.js core so we can get this sorted in advance of updating npm |
1 pending reviewer npm/cli-team.lol what does this mean? |
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: nodejs#30066
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
We've landed the patch in Node.js core and are planning a release for later today PR for 13.0.1 opened nodejs/node#30081 |
thanks @ljharb and @MylesBorins 🎉 we'll make sure to include it in the planned upcoming release, seeing that the patch already landed on node we're going to stick to our regular schedule 😊 |
I would like to implore you to still get a release out asap. While the node
release is fixed anyone installing npm separately will still be but by the
bug, and we have seen folks report 13.0.1 not fixing their environment for
this reason.
…On Wed, Oct 23, 2019, 10:55 AM Ruy Adorno ***@***.***> wrote:
thanks @ljharb <https://github.com/ljharb> and @MylesBorins
<https://github.com/MylesBorins> 🎉
we'll make sure to include it in the planned upcoming release, seeing that
the patch already landed on node we're going to stick to our regular
schedule 😊
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#269?email_source=notifications&email_token=AADZYV7CTU44GMHK66GNDOLQQBQX5A5CNFSM4JDSOWOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBWZNI#issuecomment-545483957>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADZYVZ2RWPNID7JOU4DOVTQQBQX5ANCNFSM4JDSOWOA>
.
|
@darcyclarke Could somebody merged this PR? It's still an annoying warning and I completely agree with @isaacs |
Hello Everyone, This update is slotted to be included in a release we are putting out next week, |
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
What / Why
npm in node 13 says node 13 is unsupported.
I'll update npm in node after this is released; hopefully ASAP as node 13 released today.