-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exec workspaces #2886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
added
Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:minor
new backwards-compatible feature
pr: needs documentation
pull request requires docs before merging
and removed
pr: needs documentation
pull request requires docs before merging
labels
Mar 17, 2021
wraithgar
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We know we are going to be iterating on these more. This gets it implemented and tested.
ruyadorno
force-pushed
the
add-exec-workspaces
branch
from
March 19, 2021 16:05
14fec07
to
c045239
Compare
wraithgar
approved these changes
Mar 19, 2021
Add workspaces support to `npm exec` - Refactored logic to read and filter workspaces into `lib/workspaces/get-workspaces.js` - Added location context message when entering interactive shell using `npm exec` (with no args) - Add ability to execute a package in the context of each configured workspace Fixes: npm/statusboard#288 PR-URL: npm#2886 Credit: @ruyadorno Close: npm#2886 Reviewed-by: @wraithgar
wraithgar
force-pushed
the
add-exec-workspaces
branch
from
March 22, 2021 17:23
c045239
to
e1b3b31
Compare
This was referenced Mar 23, 2021
Merged
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: next
These items should be addressed in the next release
Release 7.x
work is associated with a specific npm 7 release
semver:minor
new backwards-compatible feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workspaces support to
npm exec
lib/workspaces/get-workspaces.js
shell using
npm exec
(with no args)configured workspace
Fixes: npm/statusboard#288