Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(find-dupes): pretty-print diff on --dry-run #2912

Closed
wants to merge 2 commits into from
Closed

feat(find-dupes): pretty-print diff on --dry-run #2912

wants to merge 2 commits into from

Conversation

chowkapow
Copy link
Contributor

npm find-dupes for v7 currently does not have a descriptive message of what packages are being added/changed/removed.
This PR will output how each package would change.

image

References

Related to #2687

TODO

  • Add test cases
  • When package version remains the same, printing change mkdirp 1.0.4 -> 1.0.4 is not useful. Need to find the actual change.

image

  • Determine how to find node module path changes like below. I'm unable to find where this info lies in the diff object.
$ npx npm@6 find-dupes
move	source-map	0.5.7	node_modules/@babel/core/node_modules/source-map		node_modules/tap/node_modules/@babel/core/node_modules/source-map
move	@babel/helper-annotate-as-pure	7.10.4	node_modules/@babel/helper-annotate-as-pure		node_modules/tap/node_modules/@babel/helper-annotate-as-pure
move	@babel/helper-builder-react-jsx	7.10.4	node_modules/@babel/helper-builder-react-jsx		node_modules/tap/node_modules/@babel/helper-builder-react-jsx
move	@babel/helper-member-expression-to-functions	7.10.5	node_modules/@babel/helper-member-expression-to-functions		node_modules/tap/node_modules/@babel/helper-member-expression-to-functions
... etc

@chowkapow chowkapow requested a review from a team as a code owner March 20, 2021 15:18
@ruyadorno ruyadorno added the Agenda will be discussed at the Open RFC call label Mar 20, 2021
@darcyclarke darcyclarke added the Release 7.x work is associated with a specific npm 7 release label Mar 23, 2021
@darcyclarke darcyclarke mentioned this pull request Mar 24, 2021
Closed
3 tasks
@darcyclarke darcyclarke added the semver:minor new backwards-compatible feature label Mar 24, 2021
@ruyadorno ruyadorno force-pushed the release-next branch 6 times, most recently from aee11af to 4b10024 Compare March 29, 2021 18:20
RonSherfey
RonSherfey suggested changes Apr 3, 2021
View reviewed changes
Copy link

@RonSherfey RonSherfey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes .1

RonSherfey
RonSherfey suggested changes Apr 3, 2021
View reviewed changes
Copy link

@RonSherfey RonSherfey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes 2

@darcyclarke darcyclarke mentioned this pull request Apr 7, 2021
Closed
@darcyclarke darcyclarke removed the Agenda will be discussed at the Open RFC call label Apr 7, 2021
@darcyclarke darcyclarke self-assigned this Apr 9, 2021
@chowkapow
Copy link
Contributor Author

chowkapow commented Apr 23, 2021 •
edited
Loading

Hey @RonSherfey, what comments did you have for this? I can't find them for some reason.

How can I achieve the styling as suggested in the RFC meeting?
needs some work on the styling (should be consistent with outdated output with standardized colums/tablet layout)

RonSherfey
RonSherfey approved these changes Apr 24, 2021
View reviewed changes
Copy link

@RonSherfey RonSherfey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes 2.0

@ruyadorno ruyadorno force-pushed the release-next branch 2 times, most recently from 6616513 to e5799e1 Compare May 31, 2021 22:39
@darcyclarke darcyclarke added this to the OSS - Sprint 35 milestone Aug 9, 2021
@wraithgar wraithgar added the Release 8.x work is associated with a specific npm 8 release label Oct 7, 2021
@wraithgar wraithgar removed the Release 7.x work is associated with a specific npm 7 release label Oct 7, 2021
@wraithgar wraithgar changed the base branch from release-next to latest March 9, 2022 18:25
@fritzy fritzy force-pushed the latest branch 2 times, most recently from 3037d35 to f3b0c43 Compare September 14, 2022 23:09
@darcyclarke darcyclarke changed the title npm find-dupes pretty print diff feat(find-dupes): pretty-print diff on --dry-run Nov 23, 2022
@chowkapow chowkapow closed this by deleting the head repository Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonSherfey RonSherfey RonSherfey approved these changes

Assignees

@darcyclarke darcyclarke

Labels
Release 8.x work is associated with a specific npm 8 release semver:minor new backwards-compatible feature
Projects
None yet
Milestone
OSS - Sprint 36
Development

Successfully merging this pull request may close these issues.
6 participants
@chowkapow @RonSherfey @wraithgar @ruyadorno @darcyclarke @lukekarrys