Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manNumberRegex in help.js #2949

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Fix manNumberRegex in help.js #2949

merged 1 commit into from
Mar 25, 2021

Commits on Mar 25, 2021

  1. Fix manNumberRegex in help.js

    The current regex will match any .[0-9]. pattern anywhere in the path, which will give incorrect results if npm is installed to a path like .../node-v14.5.5/...
    
    This change restricts it to only the last path element.
    
    PR-URL: npm#2949
    Credit: @dmchurch
    Close: npm#2949
    Reviewed-by: @wraithgar
    dmchurch authored and ruyadorno committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    95ba876 View commit details
    Browse the repository at this point in the history