Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shrinkwrap setting incorrect lockfileVersion #3978

Merged
merged 1 commit into from
Nov 3, 2021

Commits on Nov 3, 2021

  1. fix: shrinkwrap setting incorrect lockfileVersion

    Fix: #3962
    
    When created from a hidden lockfile, shrinkwrap was always setting the
    lockfileVersion to 3. The shrinkwrap command also needed to be updated
    to log the correct message based on the lockfileVersion config instead
    of the static lockfileVersion.
    
    With these fixes, it was possible to log a better message whenever we
    are changing the lockfileVersion, either from a config or any existing
    lockfile.
    
    Lastly, the tests for shrinkwrap were completely refactored to use the
    real npm and test all conceivable scenarios, as well as removing usage
    of `util.promisify` in favor of `fs.promises` now that we've dropped
    support for Node 10.
    
    PR-URL: #3978
    Credit: @lukekarrys
    Close: #3978
    Reviewed-by: @wraithgar
    lukekarrys committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e5bfdac View commit details
    Browse the repository at this point in the history