Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: command completion #4032

Merged
merged 1 commit into from
Nov 10, 2021
Merged

fix: command completion #4032

merged 1 commit into from
Nov 10, 2021

Conversation

wraithgar
Copy link
Member

The fake npm object in the tests wasn't returning an async function

Fixes: #4020

@wraithgar wraithgar requested a review from a team as a code owner November 10, 2021 16:32
@wraithgar wraithgar added Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes labels Nov 10, 2021
@wraithgar wraithgar force-pushed the gar/completion-fix branch 4 times, most recently from 6576f29 to c0df220 Compare November 10, 2021 22:27
The fake npm object in the tests wasn't returning an async function

Fixes: #4020

PR-URL: #4032
Credit: @wraithgar
Close: #4032
Reviewed-by: @lukekarrys
@wraithgar wraithgar merged commit 72ca4a4 into release-next Nov 10, 2021
@wraithgar wraithgar deleted the gar/completion-fix branch November 10, 2021 22:36
@fritzy fritzy mentioned this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants