Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arborist): correctly load overrides on workspace edges, closes #4205 #4327

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Jan 25, 2022

No description provided.

@nlf nlf requested a review from a team as a code owner January 25, 2022 23:24
@nlf nlf added the ws:arborist Related to the arborist workspace label Jan 25, 2022
@npm-robot
Copy link
Contributor

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 60.564 ±4.65 28.471 ±0.08 23.977 ±7.54 18.167 ±0.94 2.492 ±0.03 2.520 ±0.01 2.104 ±0.08 10.481 ±0.20 2.022 ±0.01 3.093 ±0.00
#4327 0.379 ±0.01 0.364 ±0.00 0.369 ±0.01 0.370 ±0.02 0.356 ±0.01 0.383 ±0.00 0.375 ±0.01 0.345 ±0.00 0.365 ±0.02 0.347 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.835 ±2.11 20.816 ±0.19 11.734 ±0.22 12.919 ±0.72 2.326 ±0.02 2.449 ±0.10 2.074 ±0.05 7.512 ±0.05 2.000 ±0.00 2.668 ±0.03
#4327 0.351 ±0.00 0.346 ±0.00 0.368 ±0.01 0.391 ±0.00 0.354 ±0.01 0.352 ±0.01 0.376 ±0.00 0.385 ±0.00 0.382 ±0.00 0.378 ±0.01

@wraithgar wraithgar changed the base branch from latest to release-next January 26, 2022 19:31
@ruyadorno ruyadorno merged commit fabcf43 into release-next Jan 26, 2022
@ruyadorno ruyadorno deleted the nlf/arborist-fix-workspace-overrides branch January 26, 2022 20:54
@wraithgar wraithgar mentioned this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ws:arborist Related to the arborist workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants