Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add --save-bundle to --save usage output #4388

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

wraithgar
Copy link
Member

No description provided.

@wraithgar wraithgar requested a review from a team as a code owner February 8, 2022 19:24
@wraithgar
Copy link
Member Author

Supplemental fix to #3174

Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i clicked approve too soon, the docs test shows you have a dirty git state

@wraithgar
Copy link
Member Author

I ran the docs tests! Ugh.

@npm-robot
Copy link
Contributor

npm-robot commented Feb 8, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 53.839 ±3.60 37.670 ±0.91 28.533 ±6.19 25.243 ±0.94 3.470 ±0.10 3.626 ±0.18 2.883 ±0.08 16.269 ±0.50 2.879 ±0.00 3.997 ±0.04
#4388 0.540 ±0.00 0.508 ±0.00 0.520 ±0.02 0.518 ±0.02 0.517 ±0.00 0.528 ±0.02 0.519 ±0.01 0.536 ±0.01 0.569 ±0.03 0.505 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 39.220 ±0.20 31.219 ±0.63 17.472 ±0.06 18.792 ±0.31 3.462 ±0.04 3.498 ±0.03 3.146 ±0.02 12.219 ±0.59 2.919 ±0.04 3.994 ±0.06
#4388 0.526 ±0.01 0.551 ±0.06 0.531 ±0.01 0.517 ±0.01 0.524 ±0.02 0.501 ±0.00 0.518 ±0.02 0.518 ±0.02 0.529 ±0.02 0.537 ±0.00

@wraithgar wraithgar merged commit f3fbeea into release-next Feb 8, 2022
@wraithgar wraithgar deleted the gar/document-save-peer branch February 8, 2022 20:47
@nlf nlf mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants