Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: columnify@1.6.0 and dedupe vulnerable deps #4459

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

lukekarrys
Copy link
Contributor

Closes #3785
Closes #4373

@lukekarrys lukekarrys requested a review from a team as a code owner February 22, 2022 23:46
@lukekarrys
Copy link
Contributor Author

I also took a look at why we use 3 dependencies for cli table/column formatting (cli-table3, columnify, cli-columns). They each do something slightly differently for us, and while it may be worthwhile trying to find a single dep to do all three, that is outside the scope of this PR.

@npm-robot
Copy link
Contributor

npm-robot commented Feb 23, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 52.206 ±1.07 32.649 ±0.16 37.270 ±24.92 21.986 ±0.77 3.231 ±0.10 3.281 ±0.05 2.645 ±0.14 12.477 ±0.09 2.562 ±0.04 3.745 ±0.02
#4459 0.467 ±0.00 0.458 ±0.00 0.447 ±0.01 0.456 ±0.00 0.457 ±0.01 0.450 ±0.00 0.445 ±0.00 0.476 ±0.03 0.454 ±0.00 0.464 ±0.02
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 38.541 ±1.07 25.538 ±0.08 14.450 ±0.12 15.405 ±0.26 2.864 ±0.00 2.958 ±0.05 2.609 ±0.04 9.524 ±0.01 2.405 ±0.00 3.383 ±0.03
#4459 0.472 ±0.01 0.498 ±0.04 0.479 ±0.01 0.472 ±0.01 0.453 ±0.01 0.452 ±0.00 0.459 ±0.01 0.460 ±0.01 0.464 ±0.02 0.465 ±0.02

@lukekarrys lukekarrys merged commit 5b29666 into release-next Feb 23, 2022
@lukekarrys lukekarrys deleted the lk/audit-deps branch February 23, 2022 15:28
@lukekarrys lukekarrys mentioned this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants