fix: ignore implict workspace for some commands

[fritzy]

For some commands, ignore implicit cwd workspace config and run as if no workspace filter is set.

'adduser', 'access', 'login', 'bin', 'birthday', 'bugs', 'cache', 'help-search', 'help', 'hook', 'logout', 'org', 'ping', 'prefix', 'profile', 'root', 'search', 'token'

closes #4404

Special thanks to @mshima for submitting a similar PR #4439

[npm-robot]

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	43.627 ±0.32	28.568 ±0.04	17.840 ±0.16	20.296 ±0.91	2.961 ±0.07	2.901 ±0.00	2.333 ±0.12	12.123 ±0.15	2.262 ±0.06	3.304 ±0.13
#4479	43.374 ±0.69	28.454 ±0.08	17.856 ±0.31	19.994 ±0.34	2.890 ±0.02	2.890 ±0.06	2.280 ±0.02	12.355 ±0.22	2.427 ±0.03	3.532 ±0.38

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	31.811 ±0.09	29.638 ±10.40	13.319 ±0.32	14.273 ±0.01	2.657 ±0.10	2.700 ±0.10	2.277 ±0.07	8.801 ±0.09	2.212 ±0.02	2.980 ±0.07
#4479	34.758 ±0.86	23.478 ±0.52	14.095 ±0.04	15.127 ±0.46	2.866 ±0.03	2.706 ±0.00	2.502 ±0.10	9.522 ±0.19	2.277 ±0.02	3.298 ±0.04

[antongolub]

Shouldn't ignoreImplicitWorkspace be set true for whoami?

[wraithgar]

Shouldn't ignoreImplicitWorkspace be set true for whoami?

What if a workspace has an alternate registry or auth config?

[mshima]

Adjust the comment:

Suggested change

	// only call execWorkspaces when we have workspaces explicitly set
	// or when it is implicit and not in our ignore list
	const filterByWorkspaces =
	(workspacesEnabled || workspacesFilters.length > 0)
	&& (!implicitWorkspace || !command.ignoreImplicitWorkspace)
	// only call execWorkspaces when we have workspaces explicitly set
	// and when it is not implicit or not marked as ignore implicit workspace
	const filterByWorkspaces =
	(workspacesEnabled || workspacesFilters.length > 0)
	&& (!implicitWorkspace || !command.ignoreImplicitWorkspace)

[mshima]

And implicitWorkspace shouldn't conflict with explicit workspace? Or explicit shouldn't take precedence?

[fritzy]

There's a lot of ways we could slice it. Right now, if your cwd is a workspace, it'll run the command and ignore any explicit workspace you specify. This makes sense for something like bin, which has always worked on cwd, but it could be confusing for other commands. If you're not in a workspace and and you specify one, many commands will still fail.

We could go back and forth on the best way to handle these edge cases, but ultimately, I'd rather ship and iterate. If there are cases and commands that need more tweaking, we could patch the behavior again. But for now, this gets us back to running commands that don't really care about workspaces, but generally still errors if you try to explicitly set a workspace on a command that doesn't support them.

[jedwards1211]

@wraithgar

What if a workspace has an alternate registry or auth config?

What would such a config look like? I'm having trouble finding anything about it in the npm docs

And also if so, I must fundamentally misunderstand something:

• wouldn't the alternate registry also apply to adduser, login, logout, etc?
• why does whoami say it doesn't support workspaces? Shouldn't it just get the user associated with the workspace's registry/auth config?