Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding tests and updating docs to reflect changes in registry teams API. The default developers team can no longer be removed #457

Conversation

nomadtechie
Copy link
Contributor

What / Why

The registry teams API has been updated to no longer allow the removal of the default developers team. This is PR updates the docs page for the npm teams cmd and also adds a test to document the expected behavior and HTTP response.

References

  • n/a

…eams API. The default developers team can not longer be removed
@nomadtechie nomadtechie requested a review from a team as a code owner November 8, 2019 23:41
@nomadtechie nomadtechie changed the title feat: adding tests and updating docs to reflect changes in registry teams API. The default developers team can not longer be removed feat: adding tests and updating docs to reflect changes in registry teams API. The default developers team can no longer be removed Nov 8, 2019
claudiahdz pushed a commit that referenced this pull request Nov 11, 2019
…stry teams API. The default developers team can not longer be removed

PR-URL: #457
Credit: @nomadtechie
Close: #457
Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 11, 2019
…stry teams API. The default developers team can not longer be removed

PR-URL: #457
Credit: @nomadtechie
Close: #457
Reviewed-by: @claudiahdz
@claudiahdz claudiahdz added semver:patch semver patch level for changes Release 6.x work is associated with a specific npm 6 release labels Nov 12, 2019
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
…stry teams API. The default developers team can not longer be removed

PR-URL: #457
Credit: @nomadtechie
Close: #457
Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
…stry teams API. The default developers team can not longer be removed

PR-URL: #457
Credit: @nomadtechie
Close: #457
Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
…stry teams API. The default developers team can not longer be removed

PR-URL: #457
Credit: @nomadtechie
Close: #457
Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
…stry teams API. The default developers team can not longer be removed

PR-URL: #457
Credit: @nomadtechie
Close: #457
Reviewed-by: @claudiahdz
Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This pull-request was rebased into @claudiahdz's work and is present in #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants