Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arborist): link deps lifecycle scripts #4875

Merged
merged 1 commit into from
May 10, 2022

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented May 10, 2022

  • Fixes running proper lifecycle scripts for linked deps and workspaces.
  • Added test to validate lifecycle scripts don't run twice for linked deps
  • Tweaked "reify workspaces bin files" test to also validate proper lifecycle scripts ran before check for linked bins.
  • Tweaked reify test "running lifecycle scripts of unchanged link nodes" to also validate that the install lifecycle scripts are called.

References

Fixes: #4277
Fixes: #4552
Fixes: npm/statusboard#439
Relates to: #2905

- Fixes running proper lifecycle scripts for linked deps and
  workspaces.
- Added test to validate lifecycle scripts don't run twice
  for linked deps
- Tweaked "reify workspaces bin files" test to also validate
  proper lifecycle scripts ran before check for linked bins.
- Tweaked reify test running lifecycle scripts of unchanged link
  nodes to also validate that the install lifecycle scripts are
  also called.

Fixes: npm#4277
Fixes: npm#4552
Fixes: npm/statusboard#439
Relates to: npm#2905
@ruyadorno ruyadorno requested a review from a team as a code owner May 10, 2022 02:51
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes look great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants