Canary #49
Closed
Canary #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le (#8) As discussed on npm.community[1], the fact that npm registry authentication tokens cannot be defined using environment variables does not seem justified anymore. The restriction is caused by the config loader translating * all `_` to `-` * the whole variable name to lowercase while the credential checker expects a key ending in `:_authToken`. This change fixes the problem by having the credential checker try a key ending in `:-authtoken` after it tried `:_authToken`. Fixes: https://npm.community/t/233 Fixes: npm/npm#15565 PR-URL: #8 Credit: @mkhl Reviewed-By: @zkat
Remove publish from list of commands not affected by dry-run PR-URL: #34 Credit: @joebowbeer Reviewed-By: @zkat
Fixes: #986 PR-URL: #35 Credit: @valentin2105 Reviewed-By: @zkat
PR-URL: #36 Credit: @noahbenham Reviewed-By: @zkat
`npm audit` currently exits with exit code 1 if any vulnerabilities are found of any level. Add a flag of `--audit-level` to `npm audit` to allow it to pass if only vulnerabilities below a certain level are found. Example: `npm audit --audit-level=high` will exit with 0 if only low or moderate level vulns are detected. Fixes: https://npm.community/t/245 PR-URL: #31 Credit: @lennym Reviewed-By: @zkat
Credit: @zkat
Credit: @shesek Fixes: shesek/iferr#2
Fixes: isaacs/node-tar#177 Credit: @isaacs
Fixes: npm/hosted-git-info#34 Fixes: npm/hosted-git-info#32 Fixes: npm/hosted-git-info#35 Credit: @iarna Credit: @Erveon Credit: @huochunpeng
Credit: @rvagg
ghost
self-requested a review
as a 
|
Canary should not be PRed. Please don't PR random branches. |
This was referenced Oct 5, 2022
This was referenced Nov 30, 2023
antongolub
pushed a commit
to antongolub-forks/npm-cli
that referenced
this pull request
May 18, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.