-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rootless workspace init provides suggestion #5261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no statistically significant performance changes detected timing results
|
fritzy
force-pushed
the
fritzy/workspace-init-error
branch
2 times, most recently
from
August 17, 2022 00:12
60478af
to
97549ae
Compare
nlf
suggested changes
Aug 17, 2022
fritzy
force-pushed
the
latest
branch
2 times, most recently
from
September 14, 2022 23:09
3037d35
to
f3b0c43
Compare
lukekarrys
force-pushed
the
fritzy/workspace-init-error
branch
from
January 1, 2023 23:47
97549ae
to
75a677b
Compare
lukekarrys
force-pushed
the
fritzy/workspace-init-error
branch
2 times, most recently
from
January 1, 2023 23:51
fb0cbf1
to
d7dea4e
Compare
lukekarrys
force-pushed
the
fritzy/workspace-init-error
branch
from
January 2, 2023 00:25
d7dea4e
to
8ac7abc
Compare
lukekarrys
approved these changes
Jan 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a warning message suggesting the use of
--include-workspace-root
when ENOENT is thrown for thenpm init
command when specifying one or more workspaces.