Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove npm birthday #5455

Merged
merged 1 commit into from
Sep 8, 2022
Merged

feat: remove npm birthday #5455

merged 1 commit into from
Sep 8, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Sep 1, 2022

BREAKING CHANGE: this removes the npm birthday command

Closes npm/statusboard#450

@wraithgar wraithgar requested a review from a team as a code owner September 1, 2022 14:29
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Sep 1, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 42.710 ±1.90 17.600 ±0.84 15.492 ±0.17 18.921 ±2.90 2.969 ±0.23 2.792 ±0.07 2.313 ±0.05 10.440 ±0.34 2.105 ±0.01 4.063 ±0.87
#5455 46.433 ±4.65 18.216 ±0.25 15.774 ±0.17 17.896 ±0.25 2.758 ±0.01 2.717 ±0.05 2.165 ±0.06 10.601 ±0.34 2.094 ±0.00 3.171 ±0.06
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 31.932 ±5.71 13.962 ±0.24 11.742 ±0.16 12.766 ±0.40 2.565 ±0.04 2.493 ±0.03 2.294 ±0.01 8.234 ±0.08 2.099 ±0.04 2.932 ±0.02
#5455 28.517 ±1.19 13.111 ±0.06 11.298 ±0.19 12.259 ±0.55 2.406 ±0.00 2.518 ±0.13 2.175 ±0.00 7.624 ±0.22 2.129 ±0.01 2.754 ±0.10

@nlf
Copy link
Contributor

nlf commented Sep 7, 2022

we should deprecate @npmcli/npm-birthday too

BREAKING CHANGE: this removes the `npm birthday` command
@wraithgar wraithgar merged commit 49bbb2f into latest Sep 8, 2022
@wraithgar wraithgar deleted the gar/birthday branch September 8, 2022 17:01
@wraithgar
Copy link
Member Author

we should deprecate @npmcli/npm-birthday too

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BREAKING CHANGE(birthday): Remove command
3 participants