Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default auth-type to web #5551

Merged
merged 1 commit into from
Sep 21, 2022
Merged

feat: default auth-type to web #5551

merged 1 commit into from
Sep 21, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Sep 21, 2022

BREAKING CHANGE: the default auth-type config value is now web

@wraithgar wraithgar requested a review from a team as a code owner September 21, 2022 19:26
@wraithgar wraithgar changed the title gar/auth type default feat: default auth-type to web Sep 21, 2022
@wraithgar
Copy link
Member Author

Closes npm/rfcs#629

@wraithgar
Copy link
Member Author

This is very likely to collide with #5550 once it lands. Easy to rebuild this if that happens lmk.

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Sep 21, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 46.866 ±0.21 25.100 ±0.18 36.334 ±18.89 25.905 ±1.35 3.933 ±0.06 4.146 ±0.12 3.146 ±0.06 16.309 ±0.14 3.197 ±0.07 4.829 ±0.37
#5551 0.127 ±0.00 0.126 ±0.01 0.131 ±0.00 0.138 ±0.00 0.127 ±0.01 0.127 ±0.00 0.140 ±0.01 0.150 ±0.02 0.137 ±0.00 0.136 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 34.119 ±2.19 18.753 ±0.04 17.067 ±0.10 18.047 ±0.72 3.621 ±0.01 3.621 ±0.06 3.303 ±0.03 12.068 ±0.20 3.016 ±0.00 4.063 ±0.05
#5551 0.145 ±0.01 0.128 ±0.00 0.130 ±0.01 0.133 ±0.01 0.140 ±0.01 0.130 ±0.00 0.128 ±0.00 0.141 ±0.01 0.130 ±0.00 0.128 ±0.00

BREAKING CHANGE: the default `auth-type` config value is now `web`
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants