-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: timings are now written alongside debug log files #5581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe8f1c3
to
b50ffae
Compare
found 20 benchmarks with statistically significant performance improvements
timing results
|
BREAKING CHANGE: `--timing` file changes: - When run with the `--timing` flag, `npm` now writes timing data to a file alongside the debug log data, respecting the `logs-dir` option and falling back to `<CACHE>/_logs/` dir, instead of directly inside the cache directory. - The timing file data is no longer newline delimited JSON, and instead each run will create a uniquely named `<ID>-timing.json` file, with the `<ID>` portion being the same as the debug log. - Finally, the data inside the file now has three top level keys, `metadata`, `timers, and `unfinishedTimers` instead of everything being a top level key. Closes npm/statusboard#456
b50ffae
to
7bbd88f
Compare
wraithgar
reviewed
Sep 26, 2022
wraithgar
reviewed
Sep 26, 2022
wraithgar
approved these changes
Sep 26, 2022
Also refactor all files written to the logs directory to use the same code path for file name creation.
0aaafe5
to
9f60c91
Compare
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
--timing
file changes:--timing
flag,npm
now writes timing data to afile alongside the debug log data, respecting the
logs-dir
option andfalling back to the cache dir, instead of directly inside
.npm/
.each run will create a uniquely named
<ID>-timing.json
file, with the<ID>
portion being the same as the debug log.metadata
,timers, and
unfinishedTimers` instead of everything beinga top level key.
Closes npm/statusboard#456