Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change defaults for access config #5601

Merged
merged 2 commits into from
Sep 29, 2022
Merged

change defaults for access config #5601

merged 2 commits into from
Sep 29, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Sep 28, 2022

This PR is two commits, one the breaking change to libnpmpublish, and the other a docs/logging update for the cli to be telling folks the truth. Please rebase/merge.

  • feat: default access to public
  • docs: update docs/logging for new --access default

BREAKING CHANGE: The default value of `access` is now `public`
@wraithgar wraithgar requested a review from a team as a code owner September 28, 2022 18:23
@wraithgar
Copy link
Member Author

closes npm/statusboard#508

@wraithgar
Copy link
Member Author

graph TB
subgraph "Public package"
public-package["package is public"]-->public-default-publish["publish"];
public-default-publish-->public-package;
public-package-->public-public-publish["publish --access=public"];
public-public-publish-->public-package;
public-package-->public-restricted-publish["publish --access=restricted"];

end
subgraph "Restricted package"
public-restricted-publish-->restricted-package;
restricted-package["package is restricted"]-->restricted-default-publish["publish"];
restricted-default-publish-->restricted-package;
restricted-package-->restricted-restricted-publish["publish --access=restricted"];
restricted-restricted-publish-->restricted-package;

restricted-package-->restricted-public-publish["publish --access=public"];
restricted-public-publish-->public-package;
end
Loading

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Sep 28, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 45.516 ±0.11 21.106 ±0.02 19.264 ±0.25 23.345 ±2.65 3.703 ±0.00 3.569 ±0.04 2.795 ±0.02 13.245 ±0.14 2.806 ±0.07 4.909 ±1.29
#5601 0.135 ±0.00 0.129 ±0.00 0.128 ±0.00 0.127 ±0.00 0.128 ±0.00 0.129 ±0.00 0.126 ±0.00 0.130 ±0.00 0.126 ±0.00 0.131 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.515 ±0.59 16.783 ±0.00 14.804 ±0.17 16.297 ±1.05 3.200 ±0.02 3.248 ±0.02 2.936 ±0.05 10.332 ±0.05 2.711 ±0.01 3.688 ±0.09
#5601 0.127 ±0.00 0.127 ±0.00 0.126 ±0.00 0.129 ±0.01 0.134 ±0.01 0.126 ±0.00 0.124 ±0.00 0.126 ±0.00 0.126 ±0.00 0.130 ±0.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants