Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use v3 lockfiles by default #5605

Merged
merged 1 commit into from
Oct 4, 2022
Merged

feat: use v3 lockfiles by default #5605

merged 1 commit into from
Oct 4, 2022

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Sep 29, 2022

Lockfile now default to v3 with the following behavior:

  • existing v1 lockfiles always get upgraded (unless --lockfile-version=1)
  • existing lockfiles get changed if --lockfile-version is set
  • hidden lockfiles are always v3
  • fixed bugs in lockfile version bootstrapping churn

@fritzy fritzy requested a review from a team as a code owner September 29, 2022 16:50
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Sep 29, 2022 •
edited
Loading

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 42.935 ±0.14 20.119 ±0.81 17.914 ±0.01 24.983 ±5.36 3.807 ±0.31 3.566 ±0.11 2.888 ±0.03 13.156 ±0.04 2.665 ±0.06 4.844 ±1.30
#5605 46.164 ±1.84 20.662 ±0.14 18.940 ±0.05 23.807 ±3.00 3.572 ±0.01 3.537 ±0.04 2.811 ±0.02 13.379 ±0.08 2.740 ±0.06 4.548 ±0.92
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.618 ±1.92 15.753 ±0.17 14.311 ±0.11 16.556 ±0.45 3.061 ±0.03 2.966 ±0.02 2.681 ±0.08 9.836 ±0.05 2.579 ±0.02 3.550 ±0.10
#5605 32.484 ±1.01 16.571 ±0.08 14.779 ±0.10 16.023 ±0.39 2.967 ±0.01 3.034 ±0.01 2.714 ±0.09 10.424 ±0.21 2.545 ±0.00 3.318 ±0.01

@fritzy fritzy force-pushed the fritzy/lockfile-v3 branch 2 times, most recently from 9e50c8d to 24279a3 Compare October 1, 2022 01:51
@ruyadorno
Copy link
Contributor

this looks great @fritzy 🎉

@fritzy fritzy force-pushed the fritzy/lockfile-v3 branch from 24279a3 to 8769263 Compare October 3, 2022 06:25
@wraithgar wraithgar merged commit 9609e9e into latest Oct 4, 2022
@wraithgar wraithgar deleted the fritzy/lockfile-v3 branch October 4, 2022 19:45
@github-actions github-actions bot mentioned this pull request Oct 5, 2022
Merged
@lukekarrys lukekarrys mentioned this pull request Nov 1, 2022
Closed
This was referenced Nov 5, 2022
Closed
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 16, 2022
Closed
@achrinza achrinza mentioned this pull request Nov 23, 2022
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 30, 2022
Merged
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno left review comments

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fritzy @npm-cli-bot @ruyadorno @wraithgar